Skip to content

Clarify WalletConnect connection and request risks - #6196

Open
j0ntz wants to merge 2 commits into
developfrom
jon/wc-clarify-risks
Open

Clarify WalletConnect connection and request risks#6196
j0ntz wants to merge 2 commits into
developfrom
jon/wc-clarify-risks

Conversation

@j0ntz

@j0ntz j0ntz commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Edge showed near-identical safety language at two different WalletConnect moments: the initial connection, which shares the selected public address and opens a session but moves no funds, and a later transaction or signature request, which may move assets or authorize future transfers. This separates the two.

Confirm Connection screen now reads:

Allow <dApp> to:
View your wallet address
Request approval for transactions

Smart Contract Call screen now reads:

Warning

  • Approving this request may move funds or grant permissions
  • Only continue if you trust this application and expected this request

The Smart Contract Call warning renders in AlertCardUi4, the solid UI4 warning card, instead of the outline-only Alert. Both branches of that warning (the copy above and the insufficient-fee message) use the same card, so the modal has one warning footprint.

wc_smartcontract_warning_text is replaced by wc_smartcontract_warning_point_funds and wc_smartcontract_warning_point_trust, which render as the card's two bullet points.

Copy approved by Jon Tzeng on the Asana task; the UI4 card was requested in the same comment.

Asana: https://app.asana.com/0/1215088146871429/1217260776555871

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Low Risk
User-facing copy and warning presentation only; no changes to WalletConnect signing, connection, or wallet logic.

Overview
WalletConnect now uses different risk language for session connect vs transaction/signature approval, so users aren’t told the same “funds at risk” story at both steps.

On Confirm Connection, the allowed capabilities list is reordered and reworded to emphasize viewing the wallet address first, then requesting transaction approval (wc_confirm_body in en locales).

On Smart Contract Call, the single paragraph warning is replaced by two bullet strings (funds/permissions risk and trust/expectation), rendered through AlertCardUi4 instead of the outline Alert—including the insufficient-fee branch—for a solid UI4 warning card. WcSmartContractModal also picks up minor TypeScript typing and is removed from the ESLint ignore list.

Reviewed by Cursor Bugbot for commit 3ddf212. Bugbot is set up for automated code reviews on this repo. Configure here.

@j0ntz

j0ntz commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence

confirm connection

confirm connection

connected

connected

smart contract warning

smart contract warning

Captured by the agent's in-app test run (build-and-test).

@j0ntz
j0ntz marked this pull request as ready for review September 4, 2026 09:10
@j0ntz
j0ntz force-pushed the jon/wc-clarify-risks branch from c324c9a to 3ddf212 Compare September 4, 2026 09:10
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant