Clarify WalletConnect connection and request risks - #6196
Open
j0ntz wants to merge 2 commits into
Open
Conversation
Contributor
Author
j0ntz
marked this pull request as ready for review
September 4, 2026 09:10
j0ntz
force-pushed
the
jon/wc-clarify-risks
branch
from
September 4, 2026 09:10
c324c9a to
3ddf212
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Edge showed near-identical safety language at two different WalletConnect moments: the initial connection, which shares the selected public address and opens a session but moves no funds, and a later transaction or signature request, which may move assets or authorize future transfers. This separates the two.
Confirm Connection screen now reads:
Smart Contract Call screen now reads:
The Smart Contract Call warning renders in
AlertCardUi4, the solid UI4 warning card, instead of the outline-onlyAlert. Both branches of that warning (the copy above and the insufficient-fee message) use the same card, so the modal has one warning footprint.wc_smartcontract_warning_textis replaced bywc_smartcontract_warning_point_fundsandwc_smartcontract_warning_point_trust, which render as the card's two bullet points.Copy approved by Jon Tzeng on the Asana task; the UI4 card was requested in the same comment.
Asana: https://app.asana.com/0/1215088146871429/1217260776555871
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
User-facing copy and warning presentation only; no changes to WalletConnect signing, connection, or wallet logic.
Overview
WalletConnect now uses different risk language for session connect vs transaction/signature approval, so users aren’t told the same “funds at risk” story at both steps.
On Confirm Connection, the allowed capabilities list is reordered and reworded to emphasize viewing the wallet address first, then requesting transaction approval (
wc_confirm_bodyin en locales).On Smart Contract Call, the single paragraph warning is replaced by two bullet strings (funds/permissions risk and trust/expectation), rendered through
AlertCardUi4instead of the outlineAlert—including the insufficient-fee branch—for a solid UI4 warning card.WcSmartContractModalalso picks up minor TypeScript typing and is removed from the ESLint ignore list.Reviewed by Cursor Bugbot for commit 3ddf212. Bugbot is set up for automated code reviews on this repo. Configure here.