Match wallet edit prompt to what the tap does - #6195
Open
j0ntz wants to merge 1 commit into
Open
Conversation
Contributor
Author
The Split Wallet scene promised 'edit settings' when tapping a row only opens a name field. Wallet settings exist for Monero alone, which is not splittable, so drive the instruction copy off whether a listed wallet actually declares settings.
j0ntz
marked this pull request as ready for review
September 4, 2026 08:28
j0ntz
force-pushed
the
jon/clarify-split-wallet-edit-prompt
branch
from
September 4, 2026 08:28
3203139 to
0121e82
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
The Split Wallet confirmation scene told users "Tap on wallet to edit settings", but in that flow the tap opens a modal with nothing except a Wallet Name field. The copy was generalized when Monero gained an LWS backend picker, and Monero wallets cannot be split, so the split flow never had settings to offer.
CreateWalletEditNameSceneserves both the create-wallet and split-wallet flows, so the instruction line now follows what the listed wallets actually expose: it uses the settings wording only when some listed wallet declareswalletSettingsinSPECIAL_CURRENCY_INFO(Monero is the only one), and otherwise falls back to the existingfragment_create_wallet_instructionsstring, "Tap on wallet to edit name". No new locale key, so the translations already shipped for that string are kept.Asana: https://app.asana.com/0/1215088146871429/1217847844643601
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Copy-only conditional on existing locale strings; no API or wallet-creation behavior changes.
Overview
Create/split wallet edit prompt now matches what tapping a row actually opens.
CreateWalletEditNameSceneshows "Tap on wallet to edit settings" only when at least one listed wallet has non-emptywalletSettingsinSPECIAL_CURRENCY_INFO(e.g. Monero’s backend picker); otherwise it reuses the existing "Tap on wallet to edit name" string—fixing misleading copy on split flows and other lists with name-only modals.CHANGELOG and a snapshot test were updated for the new wording.
Reviewed by Cursor Bugbot for commit 0121e82. Bugbot is set up for automated code reviews on this repo. Configure here.