Skip to content

Match wallet edit prompt to what the tap does - #6195

Open
j0ntz wants to merge 1 commit into
developfrom
jon/clarify-split-wallet-edit-prompt
Open

Match wallet edit prompt to what the tap does#6195
j0ntz wants to merge 1 commit into
developfrom
jon/clarify-split-wallet-edit-prompt

Conversation

@j0ntz

@j0ntz j0ntz commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

The Split Wallet confirmation scene told users "Tap on wallet to edit settings", but in that flow the tap opens a modal with nothing except a Wallet Name field. The copy was generalized when Monero gained an LWS backend picker, and Monero wallets cannot be split, so the split flow never had settings to offer.

CreateWalletEditNameScene serves both the create-wallet and split-wallet flows, so the instruction line now follows what the listed wallets actually expose: it uses the settings wording only when some listed wallet declares walletSettings in SPECIAL_CURRENCY_INFO (Monero is the only one), and otherwise falls back to the existing fragment_create_wallet_instructions string, "Tap on wallet to edit name". No new locale key, so the translations already shipped for that string are kept.

Asana: https://app.asana.com/0/1215088146871429/1217847844643601

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Low Risk
Copy-only conditional on existing locale strings; no API or wallet-creation behavior changes.

Overview
Create/split wallet edit prompt now matches what tapping a row actually opens. CreateWalletEditNameScene shows "Tap on wallet to edit settings" only when at least one listed wallet has non-empty walletSettings in SPECIAL_CURRENCY_INFO (e.g. Monero’s backend picker); otherwise it reuses the existing "Tap on wallet to edit name" string—fixing misleading copy on split flows and other lists with name-only modals.

CHANGELOG and a snapshot test were updated for the new wording.

Reviewed by Cursor Bugbot for commit 0121e82. Bugbot is set up for automated code reviews on this repo. Configure here.

@j0ntz

j0ntz commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence

split wallet edit name copy

split wallet edit name copy

tap opens name only modal

tap opens name only modal

monero create keeps settings copy

monero create keeps settings copy

btc create shows name copy

btc create shows name copy

Captured by the agent's in-app test run (build-and-test).

The Split Wallet scene promised 'edit settings' when tapping a row only
opens a name field. Wallet settings exist for Monero alone, which is not
splittable, so drive the instruction copy off whether a listed wallet
actually declares settings.
@j0ntz
j0ntz marked this pull request as ready for review September 4, 2026 08:28
@j0ntz
j0ntz force-pushed the jon/clarify-split-wallet-edit-prompt branch from 3203139 to 0121e82 Compare September 4, 2026 08:28
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant