Fix wallet row a11y role and token search testID - #6182
Merged
Conversation
j0ntz
marked this pull request as ready for review
August 28, 2026 23:35
j0ntz
force-pushed
the
jon/fix/manage-tokens-testid-selectors
branch
from
August 28, 2026 23:35
45af9be to
97d4b62
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
peachbits
approved these changes
Sep 3, 2026
j0ntz
force-pushed
the
jon/fix/manage-tokens-testid-selectors
branch
from
September 4, 2026 07:14
97d4b62 to
934e91c
Compare
j0ntz
enabled auto-merge
September 4, 2026 07:14
j0ntz
force-pushed
the
jon/fix/manage-tokens-testid-selectors
branch
from
September 4, 2026 07:35
934e91c to
7b692c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #6170, which merged before its Cursor Bugbot findings could be gated. Two of them are real.
FilledTextInputderives its clear control's testID as`${testID}.clearIcon`, so thetestID="manageTokensSearch"that #6170 added to the Manage Tokens search field renamed that control from the accidentalundefined.clearIcontomanageTokensSearch.clearIcon. The C000045 Add/Edit Tokens maestro flow tapsundefined.clearIconon that exact scene to clear the search field, so it can no longer clear it. This updates that one selector. The flow's otherundefined.clearIcontaps are unaffected: C000045's remaining two target the Add Custom Token modal's contract-address input, and the rename-modal and "Search Wallets" picker taps in the other flows use inputs that #6170 never touched.The wallet list row's new wrapper
Viewalso carried the same testID as theEdgeCardinside it, and had no role.EdgeCardforcesaccessible={false}on its touchable, so only the wrapper's testID reaches XCUITest and the card's copy was dead weight. The wrapper now declaresaccessibilityRole="button", so a screen reader announces the row as something to activate rather than as an inert group.Asana: https://app.asana.com/0/1215088146871429/1217587221308437
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Small a11y and E2E selector fixes on wallet list rows and one Maestro flow; no auth, payments, or send-path changes.
Overview
Follow-up to Manage Tokens search testID work: the clear control is now
manageTokensSearch.clearIconinstead ofundefined.clearIcon, so the C000045 Maestro flow can clear the search field again.Wallet list rows expose
accessibilityRole="button"on the outer wrapper (where the row testID lives), so VoiceOver/TalkBack treat the row as tappable. The duplicate testID on the innerEdgeCardis removed because the card touchable is not the accessible element tests and screen readers see.Reviewed by Cursor Bugbot for commit 7b692c8. Bugbot is set up for automated code reviews on this repo. Configure here.