fix(maestro): repair recent existing test flows - #6172
Conversation
b4a24cf to
f995b79
Compare
4806f40 to
9a1e3c7
Compare
3b87afa to
b6fdfcd
Compare
0aea92f to
2b2bec8
Compare
The tag was C000029 but the flow is C000029a; a C000029a tag-filtered run silently skipped it. Match the tag to the test ID. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2b2bec8 to
533b1b6
Compare
| <Pressable style={styles.row} onPress={handleToggle}> | ||
| <Pressable | ||
| style={styles.row} | ||
| testID={`manageTokensRow.${token.currencyCode}`} |
There was a problem hiding this comment.
use a more unique string like concatenating the currency code and displayname
There was a problem hiding this comment.
We did consider this but didn't want to complicate it too much. Making that exact change now.
There was a problem hiding this comment.
I took another look and there's a better option and that's to use the pluginId tokenId together. I didn't realize those were in scope during the first review. It's more correct since collisions are impossible. Currently, collisions are very unlikely and since it's for the testid field it's not as important to get it right. It also complicate test writing since you'll need to know how to derive the tokenId which can vary depending on plugin. I'll leave it up to you to determine if the extra headache of identifying assets is worth the cost for correctness.
533b1b6 to
e01e778
Compare
3 participants
QA owns the Maestro YAML in this PR. Developer review is limited to the three TypeScript files and their matching changelog entries below.
Review scope
Four
testIDadditions:WalletSettingsModal.tsx—walletSettingsNameInput,walletSettingsDoneButtonCreateWalletEditNameScene.tsx—splitWalletConfirmButtonManageTokensRow.tsx—manageTokensRow.<currencyCode>CHANGELOG.md— threechanged:entries covering those hooksThese expose existing controls to Maestro. There are no visible UI, behavior, or business-logic changes.
Dependency context
developnow supplies publishededge-login-ui-rn@^3.37.2. The temporary GitHub pin used for build validation is gone; 3.37.2 contains the exact spinner-ID source validated in matched Android/iOS build26083001.QA verified all four app hooks on iPhone 17 and iPhone 17e. Asana handoff