Improve transaction check for cvmfs repository - #280
Open
Neves-P wants to merge 1 commit into
Open
Conversation
The previous code does not work in hosts with multiple mounted CVMFS repositories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code does not work in hosts with multiple mounted CVMFS repositories. I missed that in my testing earlier, but testes the behaviour of the function on a host with multiple repositories and it worked as intended.
It also replaces
cvmfs_server transactionwithcvmfs_server list. This is safer thancvmfs_server transaction, which will can also open a new transaction when we don't want it to.