[#452] 핵심 로직 유닛 테스트 추가 및 PR 단위 테스트 CI 구축 - #453
Merged
Merged
Conversation
Hrepay
had a problem deploying
to
Configuration Files
August 31, 2026 01:38 — with
GitHub Actions
Failure
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Hrepay
had a problem deploying
to
Configuration Files
August 31, 2026 01:42 — with
GitHub Actions
Failure
Hrepay
had a problem deploying
to
Configuration Files
August 31, 2026 01:48 — with
GitHub Actions
Failure
Hrepay
had a problem deploying
to
Configuration Files
August 31, 2026 01:53 — with
GitHub Actions
Failure
Hrepay
had a problem deploying
to
Configuration Files
August 31, 2026 02:13 — with
GitHub Actions
Failure
Hrepay
temporarily deployed
to
Configuration Files
August 31, 2026 02:36 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 관련 이슈
Resolved #452
💡작업 내용
유닛 테스트 (EATSSU/Tests/UnitTests, 29 tests / 0.06s)
PartnershipLikeLogicTests— 찜 토글 대상 계산(토글 API 중복 호출 방지), 찜 목록 응답 해석, 최근 추가순 정렬, storeKeyAcademicNameLocalizationTests— 학과명 키 정규화(아래아·가운뎃점·괄호), 언어별 표기, 미등록/빈 문자열 폴백 — 최근 QA에서 나온 버그들의 재현 테스트MealMenuDisplayTests— 대표메뉴만 표시/전체 폴백 규칙,/meals·/menus언어 파라미터StoreCategoryMappingTests— 식당·착한가격 카테고리·제휴 필터 ↔ 서버 문자열 매핑AppLanguageSandbox— 테스트가 앱 언어를 바꿔도 UserDefaults를 원복하는 헬퍼PartnershipLikeManager의 순수 로직 3개를 static 함수로 추출 (동작 변화 없음)CI (.github/workflows/continuous-integration.yml)
EATSSU_MVC)와qa브랜치를 참조해 동작하지 않던 상태 → develop 대상 PR마다 유닛 테스트 실행으로 교체Configuration Filesenvironment의BASE_URL/KAKAO_API_KEY재사용프로젝트 설정
-all_load -ObjC가 상속돼 링크가 깨지던 문제 수정 (OTHER_LDFLAGS무효화)EATSSU-DEV스킴의 test 액션이EATSSUUnitTests를 실행하도록 수정 (⌘U로 실행 가능)💬리뷰 요구사항(선택)
Summary by CodeRabbit
버그 수정
품질 개선