Manuscript figures and variants - #53
Closed
bmusangu wants to merge 3 commits into
Closed
Conversation
Add a CFF 1.2 citation file so GitHub and Zenodo can consume structured software metadata. Record both project authors, Brooks Musangu's ORCID, the documented Harvard Medical School affiliation, repository links, the current package version, license identifier, abstract, and manuscript keywords. Normalize author capitalization in pyproject.toml and centralize the project's copyright notice in LICENSE.txt instead of repeating drifting year ranges across source files, tests, CI configuration, documentation, and manuscript plotting code. Preserve the distinct Elephant attribution in the adapted GPFA implementation. Correct the Sphinx release value from 0.1.0. to 0.1.0, keep its copyright footer aligned with the license's original publication year, and update the preprocessing example to import EventTimesToCounts from the current blockinvgpfa package.
jdrugo
requested changes
Aug 7, 2026
jdrugo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! Right now it packs too many changes into a single PR. I suggest splitting it into (at least) two PRs:
- The first should include general changes that also apply to the main branch and are independent of the manuscript assets. This includes removal of the per-file copyright notices, and addition of
CITATION.cff. These changes can be made to the main branch. - The second should contain changes that only concern the manuscript assets, that is, everything that is currently in the
manuscript_assetsfolder. This changes should be in a separate branch, and version number indocs/conf.pyandCITATION.cffshould be bumped to 0.2.0.
Please also update the year for the copyright notice in LICENSE.txt.
Collaborator
Author
|
Let's keep the branch temporarily until both new PRs have been reviewed and their contents verified. After both new PRs are merged, we shall delete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.