Repository navigation
Release 1.81.1: no busy loop with the companions off - #87
Merged
Merged
Conversation
With the Dynamic Island on and its companion off, every pass over the island's preferences flushed the companion's hearts, hourglass and gold. The flush wrote all three keys even when nothing had changed, each write posted UserDefaults.didChangeNotification, and the island answered that notification with another full preference pass. The main thread stayed around 85% busy for as long as the companion was off. NotchMascotRPGState.flush() now writes a key only when its stored value differs, so an idle flush posts nothing and the loop has nothing to feed on. A test checks that a flush with nothing new posts no preference change and that a flush with new gold still saves it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.81.1: no busy loop with the companions off
No kext changes (kexts stay at 3.40.1).
Fixed
Verification
./build.sh --test: all checks OK.