Conversation
Verified each checkable claim in the READMEs, crate-level rustdoc, docs/ reference tree, SECURITY/CONTRIBUTING and the architecture baseline against the workspace and corrected what drifted. No behaviour changes; the only Rust edits are doc comments (//! and ///) and intra-doc link paths. - BASELINE-solid-pod-rs.md: version 0.5.0-alpha.9, re-recorded every rotted file:line citation (git_mark_write 3462, no-op shim 3668, handle_patch 1619, seed_graph 1896, replay.rs/replay_store.rs, multitenant.rs), bumped to 0.1.1 / verified_commit 045c24e per its own change process. - solid-pod-rs-server README + http-endpoints.md: `git` is not a default feature; dpop-replay-cache/nip98-schnorr/nip98-replay/acl-origin/mrc20/ embedded-docs are always on via the dependency; admin provision returns podUrl `/pods/{pk}/` and is registered unconditionally; git-panel routes and OPTIONS preflight live at `/pods/{pubkey}/_git/…`; real CORS header set; real WWW-Authenticate challenge; crates.io install is live. - NIP-98 freshness window is ±60 s (TIMESTAMP_TOLERANCE), not ±120 s. - Sibling READMEs: LOC and test counts refreshed (2026-09-22), git/nostr "will close when this crate lands" → shipped, activitypub module table matches src/, idp PARITY path fixed, forge marks forks/PRs, NIP-34 announce, anchoring and marks manager as planned and states that the bundled server gates the forge with the ownership guard, not WAC. - Root README: fixed broken link to the archived ADR-059; FsBackend::new is async; git-marks are always-on only in a --features git build. - env-vars.md: dropped JSS_WORKERS / JSS_LOG_LEVEL / JSS_DISABLE_DOTFILES (no Rust consumer), added JSS_MAX_ACL_JSON_DEPTH; migrate-from-jss.md: JSS_MASHLIB is a runtime flag; ecosystem-integration.md: S3 scaffold removed in alpha.8; comparison-vs-jss: cargo install path. - examples-index.md / tutorial 03: no `standalone` example exists; use the bundled server. benchmarks.md: five benches (dpop_replay_bench added). - SECURITY.md dotfile allowlist adds .acl.meta and .account; CONTRIBUTING no longer points at a vendored JSS checkout that is not in the repo. - api.md / solid-oidc-compatibility-matrix.md version pins → alpha.9 (no oidc source change since the alpha.8 tag). - Rustdoc: crate-qualified five intra-doc links in the server crate that fail under -D rustdoc::broken-intra-doc-links (module docs merged into crate scope), so `cargo doc --no-deps` is clean for all members. Gates run locally: cargo test --workspace --all-features (1896 passed, 114 binaries), cargo doc --no-deps -D warnings -D broken-intra-doc-links for every crate, cargo test --doc --workspace --all-features, cargo fmt --check, scripts/check-diagram-staleness.sh, scripts/adr-index-gen.js. Co-Authored-By: jjohare <github@thedreamlab.uk>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-to-code alignment at
045c24e. Every checkable claim in the READMEs, crate-level rustdoc,docs/reference tree,SECURITY.md,CONTRIBUTING.mdand the architecture baseline was verified against the workspace; each mismatch below is fixed in the document (never in the code). The only Rust changes are doc comments and intra-doc link paths.Mismatch table
045c24e)README.md:206docs/adr/ADR-059-…docs/archive/adr/crates/solid-pod-rs/docs/archive/adr/ADR-059-…mdREADME.md:190,crates/solid-pod-rs/README.md:27FsBackend::new(PathBuf)used synchronouslypub async fn new(root: impl Into<PathBuf>) -> Result<Self, PodError>crates/solid-pod-rs/src/storage/fs.rs:47README.md:206,237,src/lib.rs:9default = [];git_mark_writeis a no-op shim without--features gitcrates/solid-pod-rs-server/Cargo.toml:123,src/lib.rs:3668crates/solid-pod-rs/src/lib.rs:17docs/adr/ADR-059docs/archive/adr/crates/solid-pod-rs/README.md:47,BASELINE:115,175lib.rs:3490lib.rs:3668crates/solid-pod-rs-server/src/lib.rs:3668crates/solid-pod-rs/README.md:120,209,src/lib.rs:36, serverREADME.md:149, serversrc/lib.rs:92TIMESTAMP_TOLERANCE = 60→ ±60 s (120 s total)crates/solid-pod-rs/src/auth/nip98.rs:28,147crates/solid-pod-rs/README.md:161-165, serverREADME.md:338-342src/wc -l: 3,615 / 3,240 / 6,080 / 2,666 / 864; forge 5,376; server 11,436wc -l crates/*/src/**/*.rscrates/solid-pod-rs/README.md:228.acl.metaSTATIC_ALLOWED_DOTFILESincludes.acl.metacrates/solid-pod-rs/src/security/dotfile.rs:193-205crates/solid-pod-rs-server/README.md:8max_versionREADME.md:171-179,http-endpoints.md:205,214podUrl=/<pubkey>/, pushable via/_git/{pubkey}/podUrl={base}/pods/{pubkey}/; smart-HTTP at/pods/{pubkey}/info/refs; panel API at/pods/{pubkey}/_git/*src/lib.rs:4157,4724-4726,4731-4745,tests/admin_provision.rs:10-11README.md:207-208gitrequired, which is on by default"gitis not a default featuresrc/lib.rs:4712-4718,Cargo.toml:123README.md:318-329dpop-replay-cache/nip98-schnorropt-indpop-replay-cache,nip98-schnorr,nip98-replay,acl-origin,mrc20,embedded-docscrates/solid-pod-rs-server/Cargo.toml[dependencies.solid-pod-rs]http-endpoints.md:60-63WWW-Authenticate: DPoP algs="ES256 RS256"Nostr realm="Solid", DPoP realm="Solid", Bearer realm="Solid"src/lib.rs:966http-endpoints.md:187-198gitfeature"git initstep is gatedsrc/lib.rs:4658-4663http-endpoints.md:229-252OPTIONS /_git/{pubkey}/{tail}, gated ongit,Allow-Methods: GET, POST, OPTIONS, 3 allow-headers/pods/{pubkey}/_git/{tail:.*}, ungated, full shared CORS setsrc/lib.rs:3195-3215,4716cli/mod.rs:3(//!)installadded)cli/mod.rs:29-45solid-pod-rs-idp/README.md:13../../docs/PARITY-CHECKLIST.mdcrates/solid-pod-rs/PARITY-CHECKLIST.mdsolid-pod-rs-idp/README.md:185cargo test --workspace --all-featuressolid-pod-rs-activitypub/README.md:6,20-21webfinger,nodeinfodiscovery,ssrfsrc/lib.rs:42-50solid-pod-rs-git/README.md:18,22presentPARITY-CHECKLIST.md:215,276solid-pod-rs-nostr/README.md:4,23,27presentPARITY-CHECKLIST.md:252-253,277,318solid-pod-rs-forge/README.md:17-22,45-48,forge/src/lib.rs:10-11,40-41ownershipguard, not WAC; no fork/PR/announce/marks code;anchoring/announcefeatures unusedsrc/lib.rs:71-79;grep -rn 'feature = "announce"' forge/src→ noneBASELINE:44-460.5.0-alpha.8, "four/eight alphas past"0.5.0-alpha.9; five/nineCargo.toml:15BASELINE:59-63replay.rs:70,replay_store.rs:68,replay.rs:178,replay.rs:20,174replay.rs:117,replay_store.rs:90,replay.rs:235,replay_store.rs:19-32/replay.rs:231BASELINE:82,171multitenant.rs:181-198scrub_dotdotat 184-193multitenant.rs:184BASELINE:108-110,152-153,206-208git_mark_write3317, call sites 1374/1486/1582, canonical-path 3400,handle_patch1498,seed_graph1769, ~5,059 linescrates/solid-pod-rs-server/src/lib.rsenv-vars.md:44-47JSS_WORKERS,JSS_LOG_LEVEL,JSS_DISABLE_DOTFILESconsumed byConfigLoaderJSS_MAX_ACL_JSON_DEPTHexists and was undocumentedgrep -rovercrates/*/src;wac/mod.rs:83migrate-from-jss.md:62JSS_MASHLIBis compile-time--mashlib/JSS_MASHLIBmain.rs:57ecosystem-integration.md:105CHANGELOG.md[0.5.0-alpha.8] Removedcomparison-vs-jss.md:18cargo install solid-pod-rs-serverworksexamples-index.md:12,tutorials/03:10,178cargo run --example standalonecrates/solid-pod-rs/examples/benchmarks.md:3dpop_replay_bench)Cargo.toml:359-361api.md:8,solid-oidc-compatibility-matrix.md:3src/oidcchange since the alpha.8 tag)git log v0.5.0-alpha.8..HEAD -- src/oidcSECURITY.md:113-116.account,.acl.metadotfile.rs:193-205CONTRIBUTING.md:19-20references/javascript-solid-server/"PARITY-CHECKLIST.mdls crates/solid-pod-rs/referencessrc/mempool.rs:35-40(//!)-D rustdoc::broken-intra-doc-links(module docs merged into crate scope)cargo doc --no-deps -p solid-pod-rs-serverLeft as-is (and why)
VisionFlowcheckout (BASELINE:264,274, ADR-2001…2007, PRD/DDD gap-close docs): intentional out-of-repo references, not resolvable here.CLOSEOUT-JSS-DEEPDIVE.md,security-audit-2026-08-19.md,jss-parity-upgrade-2026-04-20*.md,sprint-12-prd.md,estate-closeout/,gap-close-evidence/,agent-integration-guide.md"status refreshed … at alpha.7",comparison-vs-jss.mdalpha.7 column): true statements about a stated commit/date.ci.ymlcomments saying "all 7 members" / "six sibling crates": workflow file, not a document; noted for a follow-up.scripts/adr-index-gen.jsregenerated with no diff; all eight records valid; no governed decision changed, so noverified_commitwas touched except the baseline's own (per its change process).Gates (local)
cargo test --workspace --all-features— 1896 passed / 0 failed across 114 binaries ·cargo doc --no-deps --all-featureswith-D warnings -D rustdoc::broken-intra-doc-linksfor every member ·cargo test --doc --workspace --all-features·cargo fmt --all -- --check·scripts/check-diagram-staleness.sh·node scripts/adr-index-gen.js crates/solid-pod-rs/docs/adr.🤖 Generated by Claude Code