Add lvds to zebra mapping - #2207
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2207 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 366 366
Lines 14367 14377 +10
=======================================
+ Hits 14264 14274 +10
Misses 103 103 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DominicOram
requested changes
Sep 10, 2026
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Thanks, annoyingly this is going to break mx-bluesky and i19-bluesky:
- https://github.com/search?q=repo%3ADiamondLightSource%2Fmx-bluesky+out_pvs&type=code
- https://github.com/search?q=repo%3ADiamondLightSource%2Fi19-bluesky+out_pv&type=code
Can you make the PRs to fix it over there too?
It's also surprising to me we have no tests on setting TTL/LVDS can we add a couple?
1 task
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DiamondLightSource/crystallography-bluesky#130
Needed for DiamondLightSource/crystallography-bluesky#137
Breaking changes:
ZebraTTLOutputsis renamed toZebraOutputsas it now includes LVDS outputs.ZebraOutputPanel.out_pvsis renamed toZebraOutputPanel.out_ttl_pvsas there is now alsoZebraOutputPanel.out_lvds_pvsInstructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}