Skip to content

Add lvds to zebra mapping - #2207

Merged
DominicOram merged 5 commits into
mainfrom
add_lvds_to_zebra_mapping
Sep 11, 2026
Merged

Add lvds to zebra mapping#2207
DominicOram merged 5 commits into
mainfrom
add_lvds_to_zebra_mapping

Conversation

@jacob-williamson

@jacob-williamson jacob-williamson commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Part of DiamondLightSource/crystallography-bluesky#130
Needed for DiamondLightSource/crystallography-bluesky#137
Breaking changes:

  • ZebraTTLOutputs is renamed to ZebraOutputs as it now includes LVDS outputs.
  • ZebraOutputPanel.out_pvs is renamed to ZebraOutputPanel.out_ttl_pvs as there is now also ZebraOutputPanel.out_lvds_pvs

Instructions to reviewer on how to test:

  1. Confirm tests still pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob-williamson
jacob-williamson requested a review from a team as a code owner September 10, 2026 15:14
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.28%. Comparing base (3c6eab0) to head (5b0a1fd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2207   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files         366      366           
  Lines       14367    14377   +10     
=======================================
+ Hits        14264    14274   +10     
  Misses        103      103           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, annoyingly this is going to break mx-bluesky and i19-bluesky:

Can you make the PRs to fix it over there too?

It's also surprising to me we have no tests on setting TTL/LVDS can we add a couple?

@jacob-williamson

jacob-williamson commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@DominicOram
DominicOram merged commit cfc632d into main Sep 11, 2026
11 checks passed
@DominicOram
DominicOram deleted the add_lvds_to_zebra_mapping branch September 11, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants