fix: environment leak when function calls error - #388
Open
DeveloperC286 wants to merge 1 commit into
Open
Conversation
`evaluate_call_expression` pushed a new environment and then used `?` while evaluating the arguments and the function's block, so any error inside a call returned early without ever popping that environment. Because the REPL reuses a single `Evaluator` across lines, each such error permanently orphaned a frame: subsequent bindings landed in the leaked environment and the chain grew without bound. The body of the call is now evaluated by a helper, so the result is propagated only after the environment has been popped, pairing every push with a pop on both the success and the error paths. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P9XgLUX4gdGGRvKhnCAUs6
DeveloperC286
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.