refactor: token parsing with explicit outcome enums - #383
Merged
Conversation
DeveloperC286
changed the title
parse_integer returned None on overflow with no distinction from other unparsable input, so a literal like 99999999999999999999 surfaced the generic "Unparsable context" message instead of explaining that it doesn't fit in a signed 64 bit integer. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DjJMbX5dSjVuZWXBEuZwKS
parse_integer now returns a ParsedInteger enum so the overflow case is known for certain from ParseIntError::kind() rather than inferred by checking whether the unparsable context happens to be all digits. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DjJMbX5dSjVuZWXBEuZwKS
ParsedInteger becomes IntegerParseOutcome for clarity. parse_keyword and parse_identifier are merged into a single parse_identifier that returns IdentifierParseOutcome (Keyword/Identifier/NotAnIdentifier), moving the keyword-takes-precedence rule into that one function instead of the parse_context match tuple. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DjJMbX5dSjVuZWXBEuZwKS
DeveloperC286
force-pushed
the
claude/integer-literal-range-error-dpckmh
branch
from
September 5, 2026 10:51
e7ef52d to
297e402
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.