refactor: module structure visibility - #382
Merged
Merged
Conversation
DeveloperC286
changed the title
DeveloperC286
force-pushed
the
claude/internal-type-visibility-zckemp
branch
from
September 5, 2026 01:28
00f9320 to
b7caa92
Compare
Remove the redundant `model` module layer from lexical_analysis, syntax_analysis, and evaluator: token, syntax_tree_node, expression_precedence, object, and environment now sit directly under their parent module instead of nested under `::model::`. Types genuinely used across module boundaries (Token, the syntax_tree_node types, Object) are now `pub` and re-exported at their parent module's root, so callers use e.g. `syntax_analysis::Expression` rather than `syntax_analysis::model::syntax_tree_node::Expression`. Types and functions that are only used within their own subtree (ExpressionPrecedence, Environment, and several internal parser/ evaluator helpers) are now `pub(super)` instead of `pub(crate)`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VM5iqrGYaMJrCTS66HRuJw
Run `make fix-rust-formatting` (cargo fmt with group_imports=StdExternalCrate). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VM5iqrGYaMJrCTS66HRuJw
DeveloperC286
force-pushed
the
claude/internal-type-visibility-zckemp
branch
from
September 5, 2026 10:33
26f306e to
1c55e77
Compare
DeveloperC286
enabled auto-merge (squash)
September 5, 2026 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #51