Grids: use Fluent theme in QUnit tests (TreeList, Gantt) - #34610
Open
anna-shakhova wants to merge 3 commits into
Open
Grids: use Fluent theme in QUnit tests (TreeList, Gantt)#34610anna-shakhova wants to merge 3 commits into
anna-shakhova wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates QUnit coverage for TreeList and Gantt to run under the Fluent theme, aligning these test suites with the theme used by many other widget tests in the repo.
Changes:
- Switched QUnit test theme imports from
generic_light.css!tofluent_blue_light.css!for Gantt and several TreeList test suites. - Adjusted several pixel-based test parameters (widget heights and drag distances) to account for Fluent theme sizing differences.
- Reordered TreeList test bootstrap (
QUnit.testStart) to keep imports at the top of the file.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/gantt.tests.js | Switches the Gantt QUnit suite to the Fluent theme import. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.treeList/virtualScrolling.integration.tests.js | Uses Fluent theme and updates TreeList height in a virtual scrolling integration scenario. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.treeList/treeList.tests.js | Uses Fluent theme, repositions QUnit.testStart, and updates a few height-dependent TreeList scenarios. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.treeList/rowDragging.tests.js | Uses Fluent theme and updates drag distances for row-dragging behavior assertions. |
Suppressed comments (1)
packages/devextreme/testing/tests/DevExpress.ui.widgets.treeList/rowDragging.tests.js:133
- The drag distance is hardcoded (75px), which is theme-dependent and may cause future flaky failures if TreeList row heights change again. Using the rendered row height (or a multiple of it) would make this assertion more robust.
const pointer = pointerMock(rowsView.getRowElement(0)).start().down().move(0, 75);
anna-shakhova
force-pushed
the
qunit_fluent_treelist_main
branch
from
August 3, 2026 12:46
5a8cecd to
a0feb17
Compare
Tucchhaa
reviewed
Aug 3, 2026
| test('removing', function(assert) { | ||
| this.createInstance(options.allSourcesOptions); | ||
| // explicit height: the treeList is virtual, so all tasks must fit the render window | ||
| this.createInstance({ ...options.allSourcesOptions, height: 700 }); |
Contributor
There was a problem hiding this comment.
Why in generic there was no need for the specific height?
Contributor
Author
There was a problem hiding this comment.
cause default browser height was enough, and with fluent all rows are not fit
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
packages/devextreme/testing/tests/DevExpress.ui.widgets/ganttParts/dataSource.tests.js:63
- The comment says “inserted task” but this test is removing an existing task; the wording is misleading and makes the height rationale unclear.
// explicit height: the treeList is virtual, so the inserted task must fit the render window
Tucchhaa
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.