Repository navigation
Preserve saved map names and Wolf Link UIDs during conversion - #30
Merged
DeltaJordan merged 1 commit intoNov 2, 2026
Merged
DeltaJordan merged 1 commit into
DeltaJordan merged 1 commit into
Conversation
Owner
|
Looks good, thanks for the contribution! I'll make a release once I have time to go through the structure of the app since it needs a big overhaul. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting between Wii U and Switch currently reverses the UTF-8 values of
PlayerSavePosMapNameandWolfLink_TodayFirstDetectedUID, because their field IDs are missing from the string-hash list. For example, the synthetic map nameZ-9changes from5A 2D 39 00to00 39 2D 5A. Converting back reverses the damage again, so a round-trip check alone misses the corruption.Add both field IDs in both byte orders so their identifiers are converted while their string values are preserved. This uses the existing conversion path and requires no game files or additional runtime dependencies.
Add six synthetic regression cases covering both conversion directions for the two affected fields and an existing horse-name field. They compare the first conversion with independently constructed destination bytes, check adjacent numeric fields and headers, confirm the source and JPEG data are unchanged, and also check a round trip. The test project is included in the solution and runs in a GitHub Actions workflow.
Validation on macOS ARM64 with .NET SDK 6.0.428:
dotnet test BotwSaveManager.Core.Tests/BotwSaveManager.Core.Tests.csproj --configuration Release..savfiles. That equivalent conversion was loaded and saved successfully in a native Switch BOTW runtime.All committed fixtures are generated by the tests. No player saves, game assets, keys, or extracted game schemas are included.