Fix Dependabot and CodeQL alerts; stop duplicate cursor PRs - #354
Closed
aamoghS wants to merge 1 commit into
Closed
Conversation
Drop image-size (no patched npm release) in favor of a JPEG/PNG/WebP parser, bump sanitize-html, PostCSS, and brace-expansion, replace the polynomial markup regexes with a linear scan, and strip CR/LF from CSP and Stripe log lines. Ignore cursor/* in the feature-to-dev auto-PR workflow so github-actions does not open a second review. Co-authored-by: Aamogh <aamoghS@users.noreply.github.com>
github-actions
Bot
added
the
dependencies
Contributor
Dependency ReviewThe following issues were found:
License Issuessites/mainweb/package.json
OpenSSF Scorecard
Scanned Files
|
aamoghS
marked this pull request as ready for review
August 16, 2026 15:43
Contributor
|
Visit the preview URL for this PR (updated for commit 2e77f1c): https://hacklytics2027--pr-354-8u40146i.web.app (expires Sun, 23 Aug 2026 15:44:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c48ba34db61581e25fe2978355160b5eefe0e83f |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const forLog = body | ||
| .slice(0, MAX_REPORT_BYTES) | ||
| .replace(/[\n\r]/g, " "); | ||
| console.warn("[CSP] violation report:", forLog); |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2e77f1c. Configure here.
| if (!isHtmlSpace(prev) && prev !== "<") { | ||
| pos = on + 1; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Handler check misses slash separators
High Severity
hasInlineHandler only treats HTML whitespace and < as valid characters before on…=, but browsers also accept / and a closing quote as attribute boundaries. Payloads like `<div/onerror=…>` or `<body/onload=…>` that the old regex rejected now pass hasDangerousMarkup, including for tags not in DANGEROUS_TAGS.
Reviewed by Cursor Bugbot for commit 2e77f1c. Configure here.
|
| Filename | Overview |
|---|---|
| packages/api/src/services/image-dimensions.ts | Adds bounded parsers for the three supported image formats without exposing a concrete regression. |
| packages/api/src/routers/user.ts | Replaces the vulnerable image-size call with the new parser while retaining type and dimension limits. |
| packages/api/src/trpc.ts | Replaces vulnerable regular expressions with linear markup scanning; one grammar difference was found but has no reachable raw-HTML consequence in current callers. |
| sites/mainweb/app/(portal)/api/webhooks/stripe/route.ts | Restricts Stripe failure logs to sanitized identifiers and exception names. |
| sites/mainweb/app/api/csp-report/route.ts | Removes CR and LF characters from unauthenticated CSP reports before logging. |
| .github/workflows/feature-to-dev-pr.yml | Excludes Cursor-created branches from automatic development-target PR creation. |
| pnpm-lock.yaml | Resolves the intended patched dependency versions and removes image-size. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Profile image data URI] --> B[Decode bounded base64]
B --> C[Read PNG JPEG or WebP dimensions]
C --> D{Valid and at most 2000x2000?}
D -- Yes --> E[Persist profile image]
D -- No --> F[Reject request]
Reviews (1): Last reviewed commit: "Fix Dependabot and CodeQL alerts; stop d..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the extra github-actions PR noise and the open Dependabot / CodeQL findings on
main.PR hygiene
dev).feature-to-dev-pr.ymlnow ignorescursor/**, so cloud-agent branches only keep the human-owned PR intomain(reviewer remainsaamoghSvia CODEOWNERS). Docs stay on #352.Dependabot alerts
image-sizeICNS / JXL / HEIF infinite loops (#268–#272)image-size(no patched 2.0.3 on npm). Profile uploads now use a JPEG/PNG/WebP-only parser.sanitize-htmljavascript: URIs (#262–#263)2.17.4→2.17.5sourceMappingURLwhenfromis unset (#265–#267)8.5.18→8.5.23(direct deps + pnpm override)brace-expansionintermediate-array DoS (#264)5.0.8→5.0.9CodeQL
trpc.tson*=/javascript:(same reject-not-rewrite behaviour; existing sanitizer tests pass)console.warnError.nameonly, not the raw exceptionpnpm test: 514 passed.