Send owners and metadata when refreshing a materialization - #2443
Open
shangyian wants to merge 1 commit into
Open
Send owners and metadata when refreshing a materialization#2443shangyian wants to merge 1 commit into
shangyian wants to merge 1 commit into
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
Refreshing a cube's materializations builds its payload by hand rather than going through DruidCubeMaterializationJob, and that hand-built payload carried none of the node's attribution: no owners, no custom metadata. The query service uses those to work out who owns the resulting Maestro workflow and which data project it belongs to, so a refresh arrived with nothing to attribute the workflow to and failed. Because the refresh endpoint catches per-materialization exceptions and moves on, the caller saw a 200 with an empty list of URLs and no sign anything had gone wrong. Both paths now build their owners through a shared principal_refs helper and send the same custom metadata, so the attribution cannot drift between them.
shangyian
force-pushed
the
fix-refresh-materialization-attribution
branch
from
August 21, 2026 13:34
083f0aa to
9ca37d0
Compare
shangyian
marked this pull request as ready for review
August 21, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshing a cube's materializations builds its payload by hand rather than going through
DruidCubeMaterializationJob, and that payload doesn't include owners or custom metadata.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan