Narrow eager-load options for single-field node mutation endpoints - #2440
Open
shangyian wants to merge 1 commit into
Open
Narrow eager-load options for single-field node mutation endpoints#2440shangyian wants to merge 1 commit into
shangyian wants to merge 1 commit into
Conversation
Several node/hierarchy handlers were pulling the full default_load_options() graph (columns, parents+current, materializations, dimension_links+target node's current, required_dimensions, created_by, etc.) to read or mutate one or two fields. Trim each to only what the handler and its response model actually touch.
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
marked this pull request as ready for review
August 21, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several node/hierarchy handlers were pulling the full
default_load_options()graph to read or mutate one or two fields. This trims each down to only what the endpoint and its response output actually needs.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan