Stop over-hydrating Node ORM entities in collections endpoints - #2439
Open
shangyian wants to merge 2 commits into
Open
Stop over-hydrating Node ORM entities in collections endpoints#2439shangyian wants to merge 2 commits into
shangyian wants to merge 2 commits into
Conversation
…n endpoints
- GET /collections/ noloads Collection.nodes since CollectionInfo never
returns nodes, avoiding a selectin load of every node (and each node's
created_by/tags) per collection.
- GET /collections/{name} loads only Node.name via selectinload+load_only
and noloads created_by/tags, matching the name-only NodeNameOutput shape.
- POST /collections/{name}/nodes/ and /remove/ fetch nodes with
load_only(id, name) and noload(created_by, tags) since the nodes are
only used to mutate the join table, not returned in the 204 response.
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
marked this pull request as ready for review
August 21, 2026 13:30
Going through collection.nodes loaded every node in the collection, and each node's created_by and tags, to remove a few -- then session.refresh loaded them all again for a 204 with no body. The read-modify-write it implies also races with a concurrent edit on the same collection. Deleting the join rows takes one statement and resolves the names in a subquery, so no Node entities are loaded at all. Names matching nothing delete nothing, which is what the membership check gave. Also pass raise_if_not_exists: removing from a collection that does not exist returned None and then raised AttributeError on collection.nodes, so a 500 where the add path already returns 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /collections/keeps hydratingCollection.nodeseven thoughCollectionInfonever returns nodes, so we can remove theselectinload of every node (and each node'screated_by/tags) per collection.GET /collections/{name}now loads onlyNode.namesince that is all that's needed for the output.POST /collections/{name}/nodes/and/remove/fetch only the node name and id, since this info is all that's needed to mutate the join table.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan