Narrow ORM eager loading in materializations API - #2438
Draft
shangyian wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
List-with-all-revisions and deactivate endpoints were loading the full NodeRevision.default_load_options() graph (columns, catalog, parents, dimension_links, etc.) per historical revision just to read materializations. Narrow both to selectinload(materializations) (+ backfills where read) plus noload(created_by) to suppress its lazy="selectin" default.
shangyian
force-pushed
the
perf/materializations-hydration
branch
from
August 21, 2026 10:59
7b88e47 to
8c16094
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
List-with-all-revisions and deactivate endpoints were loading the full
NodeRevision.default_load_options()graph per historical revision just to read materializations. This change narrows both to just the materializations metadata (+ backfills where needed).Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan