Avoid ORM over-hydration in GET /users/{username} - #2433
Draft
shangyian wants to merge 3 commits into
Draft
Conversation
Replace entity-loaded Node/NodeRevision fetch (with an unused cube_elements eager-load chain plus mapper-level selectin/joined loads on created_by, node, and catalog) with a column-only select scoped to exactly the fields NodeMinimumDetail needs. Tags and edited_by are populated via targeted queries instead of relationship hydration.
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
changed the title
GET /users/{username}GET /users/{username}
…tion in GET /users/{username}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace ORM Node/NodeRevision fetch (this has an unused
cube_elementseager-load chain plus mapper-levelselectin/joinedloads oncreated_by,node, andcatalog) with a column-only select scoped to exactly the fields the output modelNodeMinimumDetailneeds. Tags andedited_byare populated via targeted queries instead of relationship hydration.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan