Bind each metric and dimension to its column on the REST path too - #2414
Open
shangyian wants to merge 1 commit into
Open
Bind each metric and dimension to its column on the REST path too#2414shangyian wants to merge 1 commit into
shangyian wants to merge 1 commit into
Conversation
POST /preaggs/register took the retired four-field shape -- metrics and dimensions as lists, with the columns in separate measure_columns and dimension_columns maps -- while the kind: preagg YAML spec had moved to declaring each reference together with the physical column that holds it. One concept spelled two ways depending on which surface you reached for. The request body now takes the same two maps, and both models enforce the same three rules from models/preagg_binding: the retired fields are refused, a list where a map belongs is refused, and a key whose column is empty is refused. Each rejection says what was found, what to write instead, and shows the whole shape in the syntax that surface is authored in, so an existing file or API client can be fixed from the message. Since the references are now the map keys on both paths, register_external_preaggregations takes the maps rather than lists plus bindings, which removes the check for a bound dimension that isn't in the grain -- unrepresentable now. Binding every dimension explicitly also means every dimension column is type-checked, which is what the YAML path already did.
✅ Deploy Preview for thriving-cassata-78ae72 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.