Remove name from externally-registered pre-aggregations - #2411
Open
shangyian wants to merge 1 commit into
Open
Conversation
The name was ceremony. Reconciliation never read it: the apply finds the
rows a spec maps to by decomposing its metrics and matching on revision,
grain and measure identity, and deletes by row identity. The column
comment claimed an availability-by-name callback, but the only callback
is POST /preaggs/{preagg_id}/availability/, addressed by integer id.
Supplying a name is now an error rather than silently ignored, on both
the deploy spec and POST /preaggs/register (which passed it unrendered
where the deploy path passed the rendered name, so the two were never
comparable anyway). The database column stays, nullable, so rows written
before this still load.
Deployment results now label a pre-aggregation by the external table it
adopts plus the grain it covers -- the table alone is ambiguous, since
one registration can produce a pre-agg per grain group.
Dropping the name also exposes a real divergence: the dry run planned
creates, updates and deletes by name membership while the apply worked
by row identity, so editing a spec's grain but keeping its name previewed
a single update where the apply did a create plus a delete. The preview
now resolves each spec to its grain groups and matching rows the same way
the apply does -- decomposition needs no query service, only the physical
column binding does -- and reports the operations the apply will perform.
A spec it cannot resolve yet (a first deploy also creates the metrics it
refers to) is reported once as UNKNOWN, and the leftover rows are then
reported as UNKNOWN too rather than promised for deletion.
✅ Deploy Preview for thriving-cassata-78ae72 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
shangyian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Externally-registered pre-aggregations asked users for a
name. It was ceremony, and dropping it exposed a real bug that this PR fixes in the same change.