Skip to content

Opt Actions Datastores into pup generation - #998

Open
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
datadog-api-spec/generated/7486
Open

dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
datadog-api-spec/generated/7486

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

PLEASE, DO NOT MERGE THIS PULL REQUEST MANUALLY. This is automatically managed by Datadog Tooling

See ddoghq/datadog-api-spec#7486 Test branch datadog-api-spec/test/kelly.sun/pup-datastores

@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner November 9, 2026 21:32
@dd-octo-sts dd-octo-sts Bot added the changelog/no-changelog Changes don't appear in changelog label Nov 9, 2026

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

The pagination hint in datastores list-items incorrectly recommends --page-limit=101 when a full page of 100 items is returned, exceeding the documented maximum and making it impossible to retrieve subsequent pages; the fix is to keep the page size constant and advance --page-offset by the number of items returned.

Open Bits AI session

🤖 Bits Code Review · Commit e442f8a

Comment on lines +272 to +273
"Results may be truncated at {l}. Use --page-limit={} or narrow the filters",
l + 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Advance the offset when suggesting the next datastore page

When datastores list-items returns a full page with --page-limit 100, metadata.next_action recommends --page-limit=101, exceeding the endpoint’s documented maximum of 100. Following that instruction cannot retrieve the remaining items. Advance --page-offset by the number returned instead.

Suggested change
"Results may be truncated at {l}. Use --page-limit={} or narrow the filters",
l + 1
"Results may be truncated at {l}. Use --page-offset={} to retrieve the next page",
page_offset.unwrap_or(0) + count as i64

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means
  • 👍 Useful: correct, and you're fixing it or will.
  • 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
  • 😕 Unclear: you can't tell what it means or why it matters.
  • 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

🤖 Bits Code Review · Open Bits AI session

@dd-octo-sts
dd-octo-sts Bot force-pushed the datadog-api-spec/generated/7486 branch from e442f8a to b821950 Compare November 9, 2026 21:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog Changes don't appear in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants