Repository navigation
Opt Actions Datastores into pup generation - #998
dd-octo-sts[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
The pagination hint in datastores list-items incorrectly recommends --page-limit=101 when a full page of 100 items is returned, exceeding the documented maximum and making it impossible to retrieve subsequent pages; the fix is to keep the page size constant and advance --page-offset by the number of items returned.
🤖 Bits Code Review · Commit e442f8a
| "Results may be truncated at {l}. Use --page-limit={} or narrow the filters", | ||
| l + 1 |
There was a problem hiding this comment.
Advance the offset when suggesting the next datastore page
When datastores list-items returns a full page with --page-limit 100, metadata.next_action recommends --page-limit=101, exceeding the endpoint’s documented maximum of 100. Following that instruction cannot retrieve the remaining items. Advance --page-offset by the number returned instead.
| "Results may be truncated at {l}. Use --page-limit={} or narrow the filters", | |
| l + 1 | |
| "Results may be truncated at {l}. Use --page-offset={} to retrieve the next page", | |
| page_offset.unwrap_or(0) + count as i64 |
React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it
What each reaction means
- 👍 Useful: correct, and you're fixing it or will.
- 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
- 😕 Unclear: you can't tell what it means or why it matters.
- 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.
🤖 Bits Code Review · Open Bits AI session
e442f8a to
b821950
Compare
PLEASE, DO NOT MERGE THIS PULL REQUEST MANUALLY. This is automatically managed by Datadog Tooling
See ddoghq/datadog-api-spec#7486 Test branch datadog-api-spec/test/kelly.sun/pup-datastores