Skip to content

Add Agent Health issues list and get endpoints - #996

Open
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
datadog-api-spec/generated/7471
Open

dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
datadog-api-spec/generated/7471

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

PLEASE, DO NOT MERGE THIS PULL REQUEST MANUALLY. This is automatically managed by Datadog Tooling

See ddoghq/datadog-api-spec#7471 Test branch datadog-api-spec/test/louis-cqrl/agent-health-public-issues

@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner November 9, 2026 15:16
@dd-octo-sts dd-octo-sts Bot added the changelog/Added Added features results into a minor version bump label Nov 9, 2026

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

Removing the unstable-operation registrations disables all account commands for Databricks, Elastic Cloud, Snowflake, and Twilio before they can send a request. Agent Health pagination guidance also recommends an out-of-range page size when a full 100-item page is returned.

Open Bits AI session

🤖 Bits Code Review · Commit 5b55df4

Comment thread src/client.rs
"v2.get_twilio_integration_account",
"v2.list_twilio_integration_accounts",
"v2.update_twilio_integration_account",
];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Restore the integration operation registrations

Removing these registrations disables all existing Databricks, Elastic Cloud, Snowflake, and Twilio account commands. Their handlers use make_api!, while the newly pinned SDK still gates these operations and returns UnstableOperationDisabledError before sending a request. Restore all 20 registrations and update the operation-count assertion to 207.

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means
  • 👍 Useful: correct, and you're fixing it or will.
  • 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
  • 😕 Unclear: you can't tell what it means or why it matters.
  • 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

🤖 Bits Code Review · Open Bits AI session

Comment on lines +179 to +180
"Results may be truncated at {l}. Use --page-size={} or narrow the filters",
l + 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Keep page size fixed in continuation guidance

When agent-health list --page-size=100 returns a full page, the continuation hint recommends --page-size=101, exceeding the endpoint's maximum and causing HTTP 400. Increasing page size also shifts page boundaries when --page-number is supplied. Direct users to the next page while preserving page size and filters.

Suggested change
"Results may be truncated at {l}. Use --page-size={} or narrow the filters",
l + 1
"Results may be truncated at {l}. Use --page-number to request the next page, keeping --page-size={l} and filters unchanged"

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means
  • 👍 Useful: correct, and you're fixing it or will.
  • 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
  • 😕 Unclear: you can't tell what it means or why it matters.
  • 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

🤖 Bits Code Review · Open Bits AI session

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Pipelines

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

CI | Check, Test & Coverage — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5b55df4 | Docs | View more details | Give us feedback!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants