chore(benchmarks): remove batched-loop sampling noise - #2498
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
Conversation
Criterion times output collection inside batched loops, so empty setup made harness bookkeeping part of short matcher and sampler measurements.
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c765273 | Docs | View more details | Give us feedback! |
BenchmarksComparisonBenchmark execution time: 2026-09-14 11:27:43 Comparing candidate commit c765273 in PR branch Found 0 performance improvements and 5 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics.
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
yannham
left a comment
There was a problem hiding this comment.
LGTM. I don't know why iter_batched has been used without any setup code/init value, this doesn't make a lot of sense to me.
|
/merge |
|
View all feedbacks in Devflow UI.
It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.
The expected merge time in
|
Criterion times output collection inside batched loops. The glob matcher and sampler benchmarks used that API with an empty setup, which made harness bookkeeping part of their short measurements.
On Apple Silicon with Rust 1.87.0, ten fresh-process measurements of the worst wildcard case narrowed from a 10.4-19.2 ns non-outlier range to 10.7-12.5 ns. The remaining outlier fell from 80.1 ns to 27.4 ns.