Conversation
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
BridgeAR
marked this pull request as ready for review
September 8, 2026 16:33
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 863cfdf | Docs | View more details | Give us feedback! |
There was a problem hiding this comment.
More details
The change moves all direct thiserror dependencies in the workspace to version 2. The lock file keeps version 1 only for external dependencies.
🤖 Datadog Autotest · Commit 69bfce1 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
BenchmarksComparisonCandidateCandidate benchmark detailsBaselineBaseline benchmark details |
VianneyRuhlmann
approved these changes
Sep 10, 2026
BridgeAR
force-pushed
the
BridgeAR/2026-09-08-thiserror-v2
branch
from
September 10, 2026 09:06
69bfce1 to
863cfdf
Compare
BridgeAR
force-pushed
the
BridgeAR/2026-09-08-thiserror-v2
branch
from
September 15, 2026 13:17
863cfdf to
bdc5466
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating libdatadog-nodejs to thiserror 2 leaves project-owned thiserror 1 dependencies in its WASM graph, and the artifact validator rejects both majors.