Conversation
zrip 0.8.7 requires Rust 1.89, so the dependency and workspace MSRV must move together. Refs: DataDog/libdatadog-nodejs#270
📚 Documentation Check Results📦
|
🔒 Cargo Deny Results📦
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: bc290a8 | Docs | View more details | Give us feedback! |
BenchmarksComparisonBenchmark execution time: 2026-09-08 15:28:17 Comparing candidate commit bc290a8 in PR branch Found 6 performance improvements and 16 performance regressions! Performance is the same for 131 metrics, 0 unstable metrics.
|
|
You can't just arbitrarily bump libdatadog's MSRV. We currently have customers using dd-trace-rs with an MSRV below 1.89. |
|
@ekump that makes sense. Do we have a documentation for what is considered internal and what must stay as is and what support guarantees we have? |
We have a policy of being at least 1 year behind the latest rust version. So 1.89 would be fine, except for the fact that we already bumped the MSRV 3 months ago. |
@BridgeAR - The documentation is a bit disjointed at the moment. I'll fix that so we have something clear. We also need to officially publish the dd-trace-rs support policy. As @paullegranddc said, when we bump the MSRV of dd-trace-rs we bump to at most one year behind latest. I'll discuss with the libdatadog guild, and our team and figure out how soon we can update the MSRV again, hopefully in Q4. |
zrip 0.8.7 requires Rust 1.89, so this moves the dependency and workspace MSRV together. It lets downstream WASM consumers use one zrip version instead of retaining the 0.6.0 stack.
Refs: DataDog/libdatadog-nodejs#270