Skip to content

fix: plug remote symbolication enum to JFR - #828

Open
kaahos wants to merge 3 commits into
mainfrom
paul.fournillon/fix-frame-native-remote-label
Open

kaahos wants to merge 3 commits into
mainfrom
paul.fournillon/fix-frame-native-remote-label

Conversation

@kaahos

@kaahos kaahos commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?:

Adds FRAME_NATIVE_REMOTE to the JFR FrameType constant pool written by Recording::writeFrameTypes, and raises the entry count from 7 to 8.

Motivation:

Frames that need remote symbolication are tagged FRAME_NATIVE_REMOTE (7), but that value was never written to the FrameType pool. In the recording, these frames pointed to a frame type with no label.

Additional Notes:

How to test the change?:

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a security review (run the dd:platform-security-review
    skill, or file a request via the PSEC review form).
    bewaire also runs automatically on every PR.
  • This PR doesn't touch any of that.
  • JIRA: [JIRA-XXXX]

Unsure? Have a question? Request a review!

@dd-octo-sts

dd-octo-sts Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

CI Test Results

Run: #36741183325 | Commit: a951daf | Duration: 17m 34s (longest job)

✅ All 32 test jobs passed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - ✅ - -
8-ibm - ✅ - -
8-j9 ✅ ✅ - -
8-librca - - ✅ ✅
8-orcl - ✅ - -
11 - ✅ - -
11-j9 ✅ ✅ - -
11-librca - - ✅ ✅
17 ✅ ✅ - -
17-graal ✅ ✅ - -
17-j9 ✅ ✅ - -
17-librca - - ✅ ✅
21 ✅ ✅ - -
21-graal ✅ ✅ - -
21-librca - - ✅ ✅
25 ✅ ✅ - -
25-graal ✅ ✅ - -
25-librca - - ✅ ✅

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 32 | Passed: 32 | Failed: 0


Updated: 2026-09-30 16:22:59 UTC

@dd-octo-sts

dd-octo-sts Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

✅ All 40 integration tests passed

📊 Dashboard · 👷 Pipeline · 📦 d8911a72

@kaahos
kaahos marked this pull request as ready for review September 30, 2026 16:08
@kaahos
kaahos requested a review from a team as a code owner September 30, 2026 16:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T16:11:25.344043Z d8911a7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d8911a7235

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1744 to +1745
buf->putVar32(FRAME_NATIVE_REMOTE);
buf->putUtf8("Native (remote)");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add regression coverage for the remote frame-type entry

Add a test that serializes a recording containing FRAME_NATIVE_REMOTE and verifies that the FrameType constant pool declares eight entries and maps key 7 to this description. This bug fix currently has no accompanying test, so the original missing-label failure—or a mismatch between the hard-coded count and entries—can recur undetected when remote symbolication is enabled.

AGENTS.md reference: AGENTS.md:L445-L446

Useful? React with 👍 / 👎.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The declared frame-type count matches all eight serialized entries, and FRAME_NATIVE_REMOTE is now emitted with its missing label.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit d8911a7 · @DataDog review to ask questions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant