Conversation
CI Test ResultsRun: #36741183325 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-09-30 16:22:59 UTC |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8911a7235
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| buf->putVar32(FRAME_NATIVE_REMOTE); | ||
| buf->putUtf8("Native (remote)"); |
There was a problem hiding this comment.
Add regression coverage for the remote frame-type entry
Add a test that serializes a recording containing FRAME_NATIVE_REMOTE and verifies that the FrameType constant pool declares eight entries and maps key 7 to this description. This bug fix currently has no accompanying test, so the original missing-label failure—or a mismatch between the hard-coded count and entries—can recur undetected when remote symbolication is enabled.
AGENTS.md reference: AGENTS.md:L445-L446
Useful? React with 👍 / 👎.
What does this PR do?:
Adds
FRAME_NATIVE_REMOTEto the JFRFrameTypeconstant pool written byRecording::writeFrameTypes, and raises the entry count from 7 to 8.Motivation:
Frames that need remote symbolication are tagged
FRAME_NATIVE_REMOTE(7), but that value was never written to theFrameTypepool. In the recording, these frames pointed to a frame type with no label.Additional Notes:
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.Unsure? Have a question? Request a review!