Skip to content

Fix release.sh script #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengyu123 merged 2 commits into from
Sep 2, 2026
Merged

Fix release.sh script #776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6b48cc
Fix
zhengyu123 Sep 1, 2026
e309c96
Review
zhengyu123 Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions utils/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,10 +648,14 @@ REQUEST_ID="release-$(date -u +%Y%m%dT%H%M%SZ)-$$-$RANDOM"

# In retry mode, don't pass source_sha — the branch HEAD may have moved since
# the original run, and the workflow rejects SHA mismatches.
if [ -n "$RETRY_RUN_ID" ]; then
SOURCE_SHA_FIELD=""
else
SOURCE_SHA_FIELD="--field source_sha=$COMMIT_SHA"
#
# This must stay an array. A quoted scalar collapses "--field" and its
# key=value argument into one argv token, which gh rejects with
# "unknown flag: --field source_sha"; an unquoted scalar would silently
# word-split and also emit a stray empty argument in retry mode.
SOURCE_SHA_ARGS=()
if [ -z "$RETRY_RUN_ID" ]; then
SOURCE_SHA_ARGS=(--field "source_sha=$COMMIT_SHA")
fi

# Trigger the workflow
Expand All @@ -664,7 +668,7 @@ if gh workflow run release-validated.yml \
--field dry_run="$DRY_RUN" \
--field skip_tests="$SKIP_TESTS" \
--field request_id="$REQUEST_ID" \
${SOURCE_SHA_FIELD:-} > "$WORKFLOW_OUTPUT" 2> "$WORKFLOW_ERROR"; then
"${SOURCE_SHA_ARGS[@]}" > "$WORKFLOW_OUTPUT" 2> "$WORKFLOW_ERROR"; then

WORKFLOW_SUCCESS=true
echo ""
Expand Down
Loading