Add LLMObs.submitFeedback for end-user feedback submission - #12129
Draft
ddog-thibault-nadin wants to merge 1 commit into
Draft
Add LLMObs.submitFeedback for end-user feedback submission#12129ddog-thibault-nadin wants to merge 1 commit into
ddog-thibault-nadin wants to merge 1 commit into
Conversation
Ports the end-user feedback SDK from dd-trace-py (#19347) and dd-trace-js (#9654) to Java. Feedback is submitted through a builder rather than overloads: with 4 target kinds, 5 value types and 3 optional fields, an overload-based API would need ~25 signatures. The builder also makes the runtime type/value coherence checks that Python and Node.js need statically impossible, since each value type has its own setter. Feedback is a v2 eval-metric concept -- event_kind, submitter and the non-score value types only exist there -- while Java evaluations post to v1. Since one batch maps to one HTTP request, the two cannot share a worker, so EvalProcessingWorker is generalised into LLMObsIntakeWorker<T> parameterised by API path, thread and batch serializer. The eval path keeps every parameter it had (queue capacity, flush interval, flush threshold, retry policy, URL and header construction) and its payload is byte-for-byte identical; only the log message wording differs, now that it is templated per payload kind. LLMObsEvalTest pins the v1 payload against regression. submitFeedback goes through its own LLMObsFeedbackProcessor interface rather than a new method on LLMObsEvalProcessor, to avoid breaking binary compatibility for external implementors of a published interface.
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: fcd1138 | Docs | Datadog PR Page | Give us feedback! |
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
ddog-thibault-nadin
added
tag: ai generated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.