Skip to content

Experiment and ControllerRevision decoupling - #3371

Draft
levan-m wants to merge 10 commits into
mainfrom
levan-m/controllerrer-decoupling
Draft

Experiment and ControllerRevision decoupling#3371
levan-m wants to merge 10 commits into
mainfrom
levan-m/controllerrer-decoupling

Conversation

@levan-m

@levan-m levan-m commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

CONTP-1742

Commits
e099c93 phase 3 followup: bind baseline to patched resourceVersion; restore transient retry
219ae31 phase 3: freshness preflight, optimistic-lock patch, reason codes
396adf1 phase 8: abort in-flight experiments missing checkpoint fields
782f881 phase 7: delete experiment-specific revision machinery
d2dfce7 phase 6: manual-change detection via ExpectedSpecHash
9d5fddc phase 5: rollback by name + GC pin
b7e9cb6 phase 3a: daemon writes rollback-target-revision annotation from Status.CurrentRevision
dba72cc phase 4: processStartSignal wiring (RollbackTargetRevision + ExpectedSpecHash; missing-checkpoint abort)
ec9da1d phase 1, 2: API scaffolding for decoupling; reconcile barrier for revisions

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Aug 18, 2026

Copy link
Copy Markdown

Pipelines

Unblock PR with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

DataDog/datadog-operator | build — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

validation | build — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

2 linting issues found: for loops can be modernized using range over int in pkg/fleet/daemon_operations.go:144 and pkg/fleet/experiment.go:155

📋 Copy fix prompt
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Before you start, set up the Datadog software-delivery tooling so you can
query the CI data yourself:

1. Check whether you already have the Datadog software-delivery MCP tools
   (e.g. a `search_datadog_ci_pipeline_events` tool) and the `unblock-pr` skill.
2. If either is missing, STOP and ask me for permission before installing
   anything. Do not install or run anything until I have said yes.
3. Only with my explicit approval, set up the Datadog software-delivery MCP
   server and skills by following:
     https://docs.datadoghq.com/getting_started/software_delivery_mcp_tools/
   then restart so the skill is picked up.
4. If I decline, skip all of the above and work from the context below alone.

Then run /unblock-pr — it will pull the CI data itself. The job context below is what we already know.

If /unblock-pr is not available — because I declined the setup above, or it did not install — work from the context below instead.

Datadog has already classified this failure as caused by changes in this PR.
Take that as given and work the fix:

1. Locate the change. Diff this branch against its base and find the change
   that produces this error. Explain the mechanism, don't just name a file:
     git fetch origin && git diff $(git merge-base origin/main HEAD)...HEAD
2. Reproduce it locally. Run the failing job's command or test before
   proposing anything.
3. Propose the smallest fix that addresses the root cause — not a workaround,
   not a broadened assertion, not a disabled or skipped test.
4. Re-run the same command to confirm, and say exactly what you ran.
5. If the failure turns out to be intermittent rather than deterministic, say
   so plainly instead of "fixing" it — that is a flaky test, and patching it
   hides the problem.

If the right move is to re-run the job rather than change code, use the job
link in the context below. For GitHub Actions: `gh run rerun <run-id> --failed`,
where the run ID is the number after `/runs/` in that URL (not the trailing
number, which is the job ID).

Branch: levan-m/controllerrer-decoupling

validation | build
Commit: e2806758c0a8ff8d32440f8c30973d2793fb37c9
Error (code / quality):
2 linting issues found: for loops can be modernized using range over int in pkg/fleet/daemon_operations.go:144 and pkg/fleet/experiment.go:155
CI job: https://github.com/DataDog/datadog-operator/actions/runs/32748494157/job/97499594117

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e280675 | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant