[CONTP-2087] feat: Add APM to DatadogInstrumentation CRD - #3192
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intoSep 10, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
Mathew-Estafanous
changed the title
Mathew-Estafanous
changed the title
Mathew-Estafanous
force-pushed
the
mathew.estafanous/ddi-crd-add-apm
branch
from
September 3, 2026 18:42
e158038 to
2323c66
Compare
Mathew-Estafanous
changed the title
Mathew-Estafanous
marked this pull request as ready for review
September 9, 2026 21:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2323c66317
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tbavelier
approved these changes
Sep 10, 2026
Mathew-Estafanous
changed the title
Mathew-Estafanous
changed the title
Mathew-Estafanous
force-pushed
the
mathew.estafanous/ddi-crd-add-apm
branch
from
September 10, 2026 19:39
b5e51e7 to
b44a5d7
Compare
gh-worker-dd-mergequeue-cf854d
Bot
merged commit Sep 10, 2026
afd288a
into
main
67 of 69 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
mathew.estafanous/ddi-crd-add-apm
branch
September 10, 2026 21:18
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Re-adding #2984 which adds a
spec.config.apmsection that'll be used to support DDI for APM. Specifically workload targeting for single step instrumentation.Motivation
DDI for APM was one of the originally intended use-cases for DDI but was put on hold as the team focused on other topics. We're now re-visiting this feature and working to add it as the last of the 3 pillars supported by DDI.
Additional Notes
config.apm.enabledistrueby default because most customers are expected to be enabling APM. However DDI is intended to allow for disabling instrumentation, should a customer wish to do so using a CR.Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Validated the CRD spec looks good.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel