Repository navigation
Conversation
The Datadog MergeQueue tests each PR on a temporary mq-working-branch-* branch with the latest main. The Rust workflow ran only for pull requests and pushes to main, so the queue did not run the required Rust checks on that branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change enabling Rust CI on MergeQueue working branches.
No open issues 🎉
What changed in this PR
Extends Rust CI to Datadog MergeQueue branches so queued PRs can run the six required Rust checks against the latest main. This supports the broader move to /merge-based merging.
Changes:
- Adds
mq-working-branch-*to the workflow’s push trigger while preserving existing triggers. - Documents the purpose of the MergeQueue branch pattern.
| File | Description |
|---|---|
.github/workflows/rs_ci.yml |
Enables Rust CI on pushes to MergeQueue working branches. |
Review effort: Balanced
jcaparelli15
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Merging PRs takes too much manual work, and the work grows with the number of PRs. The branch protection on
mainrequires a branch to be up to date before it merges. So each merge puts every other open PR behindmain. Its author must then mergemaininto the branch, wait for CI again, and merge before someone else does. When one person merges a stack of PRs, they repeat this for each PR.Plan
Move merges to the Datadog MergeQueue, with the
/mergecomment. For each PR, the queue makes a temporary branch,mq-working-branch-*, with the latestmainplus the PR. It runs CI on that branch and merges the PR only if CI passes. So the queue tests each PR against the latestmain, and the author does not update the branch.main. It waits with the blocker "branch behind base". A/mergeon #1492 showed this./mergemain, so authors do not update branches.This PR
Adds
mq-working-branch-*to the push trigger of the Rust workflow. That workflow holds the six required checks: Check, Clippy, Audit, Build All, Test Suite and Valid LICENSE-3rdparty.csv. It started only for a pull request and for a push tomain, so the queue ran only the GitLab pipeline on its branch. With this change, the queue also runs the six Rust checks onmainplus the PR before it merges.Testing
Steps
Result
main,mq-working-branch-*A queue run on this branch is not tested yet. The first
/mergeafter this PR merges will show whether the Rust checks start on the queue's branch.🤖 Generated with Claude Code