Repository navigation
fix(deps): vuln minor: @opentelemetry/core · patch: @grpc/grpc-js [integration-tests/lambda/otlp-node/package.json] - #1460
Conversation
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: df186a2 | Docs | View more details | Give us feedback! |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
The per-parent overrides leave ten copies of vulnerable @opentelemetry/core@1.27.0 in the updated lockfile, so the dependency update does not fully remove the vulnerable version.
1 open issue
1 file not reviewed
integration-tests/lambda/otlp-node/package-lock.json: Generated file
What changed in this PR
This PR updates transitive dependencies in the Node.js OTLP Lambda integration-test fixture to address reported security vulnerabilities.
Changes:
- Adds scoped npm overrides targeting
@opentelemetry/coreat^1.30.1and@grpc/grpc-jsat^1.14.6. - Updates the lockfile with gRPC 1.14.6 and revised OpenTelemetry dependency resolutions.
| File | Description |
|---|---|
integration-tests/lambda/otlp-node/package.json |
Adds transitive dependency overrides for the security updates. |
integration-tests/lambda/otlp-node/package-lock.json |
Records updated versions and nested OpenTelemetry dependencies. |
Review effort: Balanced
| "@opentelemetry/sdk-trace-node": "^1.28.0", | ||
| "@opentelemetry/semantic-conventions": "^1.28.0" | ||
| }, | ||
| "overrides": { |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 689c21c04f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| "overrides": { | ||
| "@opentelemetry/exporter-trace-otlp-grpc": { | ||
| "@opentelemetry/core": "^1.30.1", |
There was a problem hiding this comment.
Upgrade core to an actually patched release
Every new @opentelemetry/core override uses ^1.30.1, which can resolve only versions below 2.0.0, but the upstream GHSA-8988-4f7v-96qf advisory marks all versions below 2.8.0 as affected and identifies 2.8.0 as the patched release. Consequently, security scans will continue reporting the vulnerability—and baggage extraction remains vulnerable where untrusted headers reach the propagator—despite the PR summary claiming it is fixed; update the compatible OpenTelemetry package set to 2.8.0 or later rather than overriding it to another affected 1.x release.
AGENTS.md reference: AGENTS.md:L23-L23
Useful? React with 👍 / 👎.
Auto-rebase failedLockfile regeneration failed during rebase onto Error detailschild workflow execution error (type: engraver.Engraver_AllManagersWorkflow, workflowID: 01a1b462-7277-7388-8b51-6fe251986b88_69, runID: 01a1b462-8aab-7a06-a6b2-aa9a36d3e4ea, initiatedEventID: 69, startedEventID: 70): custom action(s) failed and produced no changes: [registry.ddbuild.io/images/engraver-custom-action:update-npm-lockfile] Auto-Rebase · Add |
…tion-tests/lambda/otlp-node/package.json] Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
CI installs with npm 10, which rejects the lock file that the bot wrote for the new overrides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: lym953 <10097700+lym953@users.noreply.github.com>
Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
689c21c to
df186a2
Compare

Summary: High-severity security update — 2 packages upgraded (MINOR changes included)
Manifests changed:
integration-tests/lambda/otlp-node/package.json(npm)✅ Action Required: Please review the changes below. If they look good, approve and merge this PR.
Updates
Security Details
🚨 Critical & High Severity (2 fixed)
ℹ️ Other Vulnerabilities (4)
Review Checklist
Standard review:
Update Mode: all_vulns
🤖 Generated by DataDog Automated Dependency Management System