⚗️ [RUM-18031] manual resources participate in pending-activity tracking (prototype) - #4963
Draft
bcaudan wants to merge 1 commit into
Draft
⚗️ [RUM-18031] manual resources participate in pending-activity tracking (prototype)#4963bcaudan wants to merge 1 commit into
bcaudan wants to merge 1 commit into
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 3a22369 | Docs | View more details | Give us feedback! |
Bundles Sizes Evolution
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Prototype for the electron-sdk IPC RUM events work: manual resources (started/stopped via the public manual resource API) did not hold page activity "busy" the way real network requests do, so IPC-driven activity could be missed by pending-activity tracking (e.g. view loading time, action duration).
Changes
trackManualResourcesnow notifiesREQUEST_STARTED/REQUEST_COMPLETEDlife-cycle events when a manual resource starts/stops, so it participates in pending-activity tracking likefetch/XHRrequests.getNextRequestIndex()export inrequestCollectionto share request indexing with manual resources.RequestType.OTHERtoresourceUtilsfor manual resources reported through this path.Test instructions
yarn test:unit --spec packages/browser-rum-core/src/domain/resource/trackManualResources.spec.tsREQUEST_STARTED/REQUEST_COMPLETEDare fired and page activity is held busy while a manual resource is in flight.Checklist