Repository navigation
fix(ci): Foxy build and tests green - #12
Merged
Merged
Conversation
agus-darmawan
added a commit
that referenced
this pull request
Nov 1, 2026
fix(ci): Foxy build and tests green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
With
DHARMA_TOKENset, CIbuild-test (foxy)got further and found real problems. This branch makes it green: Foxy build of the whole workspace (25 packages) + 170 tests, 0 failures.Cannot locate rosdep definition for [fast_lio]fast_lio legkilo livox_ros_driver2in CI and inscripts/setup.sh install rosdep(same as Dharma's CI)TfResult.pose2dis a property, called as a method → the return thread crashedresult.pose2dnavigation/status(depth 1) coalesced FOLLOWING into GOAL_REACHED, so the "seen active" guard ignored the endnear_m"near_m(out-and-back still returns the short way); unit test addedHow it was tested
Checklist
test/rosagainst a fake stack on FoxyGenerated by Claude Code