fix(deploy): strip-components=1 for cargo-dist archive extraction - #147
Merged
Conversation
cargo-dist archives dk-{target}.tar.gz with a top-level subdirectory
dk-{target}/ — the binary is at dk-{target}/dk, not at root.
Add --strip-components=1 so `chmod +x dk` finds the binary.
Broke in v0.7.1 when artifact names changed from dakera-cli-*.tar.xz
to dk-*.tar.gz (PR#126).
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deploy Binary workflow fails with
chmod: cannot access 'dk': No such file or directorywhen extracting fromdk-x86_64-unknown-linux-gnu.tar.gz.cargo-dist wraps the binary in a top-level directory (
dk-x86_64-unknown-linux-gnu/dk), not at archive root. The extract step was missing--strip-components=1.Root Cause
Broke in v0.7.1 after PR#126 renamed artifacts from
dakera-cli-*.tar.xz→dk-*.tar.gz. The old.tar.xzformat also had a subdirectory, but this wasn't tested.Fix
Verification
Confirmed locally:
With
--strip-components=1,dklands at root andchmod +x dksucceeds.Follow-up
After merge, manually re-run the Deploy Binary workflow on v0.7.1 release to complete the binary deployment.