3Dmol DNA - #56
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd5380be3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import BaseLayout from '../layouts/BaseLayout.astro'; | ||
| import ButtonLink from '../components/ui/ButtonLink.astro'; | ||
| import DBTLCycleDisplay from '../components/DBTLCycleDisplay.astro'; | ||
| import MolecularDnaViewer from '../components/MolecularDnaViewer.astro'; |
There was a problem hiding this comment.
The commit tree does not contain src/components/MolecularDnaViewer.astro (confirmed by a repository-wide file search and git ls-tree), so Astro cannot resolve this new import and every homepage typecheck/build—including the deployment workflow's pnpm build:production—fails before producing the site. Commit the component and any assets it requires, or retain the existing DNA implementation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@codex good catch, please fix this issue.
There was a problem hiding this comment.
Summary
- Added the missing
MolecularDnaViewer.astrocomponent, resolving the homepage’s broken component import. The component includes an inline SVG fallback so the visualization remains available before JavaScript loads or if WebGL initialization fails. src/components/MolecularDnaViewer.astroL1-L39 - Added an on-demand 3Dmol.js visualization of the J23101 promoter sequence, including complementary strands, base-specific colors, rotation/zoom interaction, and reset controls. src/components/MolecularDnaViewer.astroL41-L134
- Committed the changes in commit
ea8780c(Add molecular DNA viewer component). - PR creation was attempted with
gh pr create, but the environment has no GitHub authentication configured and does not expose the requestedmake_prtool.
Testing
- ✅
pnpm typecheck - ✅
pnpm lint - ✅
git diff --check ⚠️ pnpm install --frozen-lockfile(the npm registry returned HTTP 403 while downloadingpako@2.2.0)⚠️ pnpm build:production(could not complete because the interrupted dependency restoration left the local3dmolpackage unavailable)⚠️ gh pr create --title "Add missing molecular DNA viewer component" ...(GitHub CLI requiresGH_TOKENor an authenticated login in this environment)
| "format:check": "prettier --check .", | ||
| "test": "pnpm test:content && pnpm test:smoke", | ||
| "test": "pnpm test:model && pnpm test:content && pnpm test:smoke", | ||
| "test:model": "node scripts/check-j23101-model.mjs", |
There was a problem hiding this comment.
The referenced scripts/check-j23101-model.mjs is absent from the commit tree, so pnpm test now stops immediately with MODULE_NOT_FOUND at test:model and never reaches the existing content or smoke tests. This breaks the CI workflow's Test step on every run; add the script or remove this test entry until it exists.
Useful? React with 👍 / 👎.
1 participant
No description provided.