Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/web/src/app/[locale]/smartphones/[slug]/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,7 @@ export async function ProductDetailView({
// renders them for its own master, an Item page once per size (#1154).
const renderPriceHistory = (v: {
product: { name: string };
offers: typeof offers;
priceHistory: typeof priceHistory;
minPrice: number;
radarSignal: typeof radarSignal;
Expand All @@ -773,6 +774,7 @@ export async function ProductDetailView({
currentMinPrice: v.minPrice > 0 ? v.minPrice : null,
}}
radarSignal={v.radarSignal}
offers={v.offers}
/>
);
const renderOffersBody = (v: {
Expand Down Expand Up @@ -1631,6 +1633,7 @@ export async function ProductDetailView({
)
: renderPriceHistory({
product,
offers,
priceHistory,
minPrice: currentMinPrice,
radarSignal,
Expand Down
200 changes: 169 additions & 31 deletions apps/web/src/components/price-history/PriceHistorySection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,25 @@ import {
evaluateOmnibusPriceAudit,
formatOmnibusAuditCopy,
resolveOmnibusReferenceAnchorMs,
sanitizeOmnibusPriceVnd,
type OmnibusPriceAuditResult,
type OmnibusReferenceOfferInput,
type OmnibusVerdictTranslator,
} from '@/lib/omnibus-price-audit';
import {
minimumListingPriceVnd,
normalizeOfferId,
plausibleOffers,
} from '@repo/shared-data/rules';
import {
isOfferUnavailable,
type OfferAvailability,
toOfferAvailability,
} from '@/lib/product-market-stats';
import {
MAX_VALID_VND_PRICE,
type DiscountVerdictType,
type MasterProductPriceHistorySummary,
type OfferAvailability,
type OfferDiscountAnalysis,
type PriceHistoryPoint,
} from '@/lib/rate-domain';
Expand Down Expand Up @@ -679,34 +682,112 @@ export default function PriceHistorySection({
return Math.round(raw);
}, [history.currentMinPrice]);

const safeOffersInput = useMemo<OmnibusReferenceOfferInput[]>(
() =>
Array.isArray(offers)
? offers.filter((off): off is OmnibusReferenceOfferInput =>
Boolean(off && typeof off === 'object' && !Array.isArray(off))
)
: [],
[offers]
);

// Identify unavailable (sold-out / discontinued) offers from explicit `offers`,
// optional `availability` on `offerAnalyses`, prices strictly below the
// verified in-stock minimum (DOS/Rate#1141), or `rate-api`'s unavailable
// suppression signature (`normal_price` despite qualifying for `genuine_deal`).
// explicit `availability` on `offerAnalyses`, or fallback heuristics when
// availability is unknown (prices strictly below the verified in-stock minimum,
// DOS/Rate#1141, or `rate-api`'s unavailable `normal_price` suppression).
const unavailableOfferIds = useMemo<Set<string>>(() => {
const ids = new Set<string>();
const addId = (rawId: string | null | undefined) => {
if (!rawId) return;
if (typeof rawId !== 'string') return;
const trimmed = rawId.trim();
if (!trimmed) return;
ids.add(rawId);
const canon = normalizeOfferId(rawId);
ids.add(trimmed);
const canon = normalizeOfferId(trimmed);
if (canon) ids.add(canon);
};

if (Array.isArray(offers)) {
for (const off of offers) {
if (off && isOfferUnavailable(off)) {
addId(off.id);
const setAvailInMap = (
map: Map<string, OfferAvailability>,
rawId: string | null | undefined,
avail: OfferAvailability
) => {
if (typeof rawId !== 'string') return;
const trimmed = rawId.trim();
if (!trimmed) return;
const canon = normalizeOfferId(trimmed);
for (const key of [rawId, trimmed, canon]) {
if (!key) continue;
const prev = map.get(key);
if (!prev || isOfferUnavailable({ availability: avail })) {
map.set(key, avail);
}
}
};

const explicitAvailFromAnalyses = new Map<string, OfferAvailability>();
for (const oa of offerAnalyses) {
const avail = toOfferAvailability(oa.availability);
if (avail) {
setAvailInMap(explicitAvailFromAnalyses, oa.product_id, avail);
}
}

const explicitAvailFromOffers = new Map<string, OfferAvailability>();
for (const off of safeOffersInput) {
const rawId =
typeof off.id === 'string' && off.id.trim()
? off.id
: typeof off.product_id === 'string' && off.product_id.trim()
? off.product_id
: null;
const avail = toOfferAvailability(off.availability);
if (avail) {
setAvailInMap(explicitAvailFromOffers, rawId, avail);
if (isOfferUnavailable({ availability: avail })) {
addId(rawId);
}
continue;
}
if (!rawId) continue;
const trimmed = rawId.trim();
const canon = normalizeOfferId(trimmed);
const oaAvail =
explicitAvailFromAnalyses.get(rawId) ??
explicitAvailFromAnalyses.get(trimmed) ??
(canon ? explicitAvailFromAnalyses.get(canon) : undefined);
if (oaAvail) {
if (isOfferUnavailable({ availability: oaAvail })) {
addId(rawId);
}
continue;
}
const p = Number(off.price_current);
if (
safeCurrentMinPrice != null &&
Number.isFinite(p) &&
p > 0 &&
Math.round(p) < safeCurrentMinPrice
) {
addId(rawId);
}
}

for (const oa of offerAnalyses) {
const maybeAvail = (oa as { availability?: OfferAvailability | null })
.availability;
if (maybeAvail && isOfferUnavailable({ availability: maybeAvail })) {
addId(oa.product_id);
const canonOaId = normalizeOfferId(oa.product_id);
const explicitAvail =
explicitAvailFromOffers.get(oa.product_id) ??
explicitAvailFromOffers.get(oa.product_id.trim()) ??
(canonOaId ? explicitAvailFromOffers.get(canonOaId) : undefined) ??
toOfferAvailability(oa.availability);
if (explicitAvail) {
if (isOfferUnavailable({ availability: explicitAvail })) {
addId(oa.product_id);
}
continue;
}

const p = Number(oa.price_current);
if (
safeCurrentMinPrice != null &&
Expand Down Expand Up @@ -741,28 +822,79 @@ export default function PriceHistorySection({
}
}
return ids;
}, [offerAnalyses, offers, safeCurrentMinPrice]);
}, [offerAnalyses, safeCurrentMinPrice, safeOffersInput]);

const isUnavailId = useCallback(
(id: string) =>
unavailableOfferIds.has(id) ||
unavailableOfferIds.has(id.trim()) ||
unavailableOfferIds.has(normalizeOfferId(id)),
[unavailableOfferIds]
);

const effectiveReferenceOffers = useMemo<OmnibusReferenceOfferInput[]>(
() =>
Array.isArray(offers) && offers.length > 0
? [...offers]
: offerAnalyses.map((oa) => ({
id: oa.product_id,
price_current: oa.price_current,
availability: isUnavailId(oa.product_id)
? ('out_of_stock' as const)
: ('in_stock' as const),
})),
[isUnavailId, offerAnalyses, offers]
);
const effectiveReferenceOffers = useMemo<OmnibusReferenceOfferInput[]>(() => {
if (safeOffersInput.length > 0) {
return safeOffersInput.map((off) => {
const rawId =
typeof off.id === 'string' && off.id.trim()
? off.id
: typeof off.product_id === 'string' && off.product_id.trim()
? off.product_id
: undefined;
const explicit = toOfferAvailability(off.availability);
const explicitUnavailable =
explicit != null && isOfferUnavailable({ availability: explicit });
const unavailable =
explicitUnavailable || Boolean(rawId && isUnavailId(rawId));
return {
id: rawId,
price_current: off.price_current,
availability: unavailable
? explicitUnavailable
? explicit
: ('out_of_stock' as const)
: ('in_stock' as const),
implausiblyLow: off.implausiblyLow,
};
});
}
return offerAnalyses.map((oa) => {
const explicit = toOfferAvailability(oa.availability);
const explicitUnavailable =
explicit != null && isOfferUnavailable({ availability: explicit });
const unavailable = explicitUnavailable || isUnavailId(oa.product_id);
return {
id: oa.product_id,
price_current: oa.price_current,
availability: unavailable
? explicitUnavailable
? explicit
: ('out_of_stock' as const)
: ('in_stock' as const),
};
});
}, [isUnavailId, offerAnalyses, safeOffersInput]);

const allKnownOffersUnavailable = useMemo<boolean>(() => {
if (effectiveReferenceOffers.length === 0) return false;
const inStockSized: { id: string; price_current: number }[] = [];
effectiveReferenceOffers.forEach((off, idx) => {
if (isOfferUnavailable(off) || off.implausiblyLow === true) return;
const price = sanitizeOmnibusPriceVnd(
off.price_current,
minValidPriceVnd
);
if (price == null) return;
inStockSized.push({
id:
typeof off.id === 'string' && off.id.trim()
? off.id.trim()
: `__idx_${idx}`,
price_current: price,
});
});
return plausibleOffers(inStockSized).length === 0;
}, [effectiveReferenceOffers, minValidPriceVnd]);

// Historical anchor uses the exact same evidence-eligibility rules as the
// Omnibus evaluator so rows below `minValidPriceVnd`, `live_listing` rows,
Expand Down Expand Up @@ -881,12 +1013,18 @@ export default function PriceHistorySection({
return evaluateOmnibusPriceAudit({
...omnibusSharedOpts,
points: validPoints,
currentPriceVnd: safeCurrentMinPrice,
claimedOriginalPriceVnd: bestClaimedOrig,
currentInStockPriceVnd: safeCurrentMinPrice,
currentPriceVnd: allKnownOffersUnavailable ? null : safeCurrentMinPrice,
claimedOriginalPriceVnd: allKnownOffersUnavailable
? null
: bestClaimedOrig,
currentInStockPriceVnd: allKnownOffersUnavailable
? null
: safeCurrentMinPrice,
currentOfferUnavailable: allKnownOffersUnavailable,
mode: 'market',
});
}, [
allKnownOffersUnavailable,
isUnavailId,
offerAnalyses,
omnibusByOffer,
Expand Down
1 change: 1 addition & 0 deletions apps/web/src/components/product/item/ItemLazySizePanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ function renderSize(
currentMinPrice: data.stats.minPrice > 0 ? data.stats.minPrice : null,
}}
radarSignal={data.radarSignal}
offers={data.offers}
/>
);
}
Expand Down
10 changes: 10 additions & 0 deletions apps/web/src/lib/__tests__/offer-plausibility.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,18 @@ async function main() {
history.byOffer['sold-out-cheap-real']?.verdict,
'normal_price'
);
assert.equal(
history.byOffer['sold-out-cheap-real']?.availability,
'out_of_stock'
);
assert.equal(
history.byOffer['sold-out-high']?.availability,
'discontinued'
);
assert.equal(history.byOffer['in-stock-3']?.verdict, 'normal_price');
assert.equal(history.byOffer['in-stock-3']?.availability, 'in_stock');
assert.equal(history.byOffer['in-stock-1']?.verdict, 'genuine_deal');
assert.equal(history.byOffer['in-stock-1']?.availability, 'in_stock');
assert.equal(history.genuineDealCount, 1);

// Zero in-stock offers: safe fallback drops sold-out 500k bait among sold-out peers.
Expand Down
Loading
Loading