Skip to content

feat(web): propagate explicit offer availability into OfferDiscountAnalysis and PriceHistorySection #1871

Closed

Description

@JOY

Context

Follow-up from PR #1869 (Package 8A Feature F1 - 30-day EU Omnibus price-floor check and 90-day cycle signal, #1863).

PriceHistorySection already accepts an optional offers prop (readonly OmnibusReferenceOfferInput[]) and applies availability heuristics when offers is omitted, but product detail route callers (apps/web/src/app/[locale]/[category]/[slug]/page.tsx and ItemLazySizePanel.tsx) do not yet forward offers, and OfferDiscountAnalysis in apps/web/src/lib/rate-api.ts / rate-domain.ts does not carry availability directly from offerUnavailable.

Acceptance Criteria

  1. Include optional availability?: OfferAvailability on OfferDiscountAnalysis in rate-domain.ts and populate it in rate-api.ts (getMasterProductPriceHistory).
  2. Forward offers into PriceHistorySection from product detail route callers and ItemLazySizePanel.tsx.
  3. Add a unit test verifying a sold-out normal_price offer priced at or above currentMinPrice is excluded from Omnibus prior-floor and 90-day cycle inputs even when offers is omitted.

Activity

  1. added
    status:readyTask ready to be picked up by an Agent
    bugSomething isn't working
    po:antigravityDispatched by the Antigravity Product Owner
    on Nov 22, 2026
  2. added theissue type on Nov 22, 2026
  3. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    🔒 [Agent: Core] Claim lock refs/claims/1871 taken by claimant antigravity:11787661-5a2c-4e90-a023-d1c4d248212d (Status: in-progress).

  4. added
    status:in-progressTask currently claimed and being worked on by an Agent
    and removed
    status:readyTask ready to be picked up by an Agent
    on Nov 22, 2026
  5. self-assigned this
    on Nov 22, 2026
  6. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    [Agent: Core] Claimed this issue on branch fix/1871-omnibus-offer-availability (Claimant: antigravity:11787661-5a2c-4e90-a023-d1c4d248212d). Propagating explicit availability into OfferDiscountAnalysis, forwarding offers to PriceHistorySection across product detail routes and ItemLazySizePanel, and adding regression unit coverage.

  7. added
    status:in-reviewTask completed and waiting for review / PR merge
    and removed
    status:in-progressTask currently claimed and being worked on by an Agent
    on Nov 22, 2026
  8. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    [Agent: Core] Opened PR #1872 (fix/1871-omnibus-offer-availability -> dev, head e291297e). Local pnpm typecheck, pnpm lint, pnpm --filter @repo/web test, and pnpm build passed; awaiting CI checks and Round-2 review confirmation.

  9. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    🔓 [Agent: Core] Claim lock refs/claims/1871 of antigravity:11787661-5a2c-4e90-a023-d1c4d248212d (Agent Core) since 2026-11-22T17:15:10Z released by claimant antigravity:def296a6-5f67-48da-bb74-ee3ede4b7061 because #1871 is closed (Status: done).

  10. added
    status:doneTask completed and verified
    and removed
    status:in-reviewTask completed and waiting for review / PR merge
    on Nov 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

agent:corearea:webbugSomething isn't workingpo:antigravityDispatched by the Antigravity Product Ownerstatus:doneTask completed and verified

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions