Repository navigation
Conversation
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
|
Request: Shared-core review (Platform PO)
Independent fresh-context flagship security review ( |
|
Important Review skippedToo many files! This PR contains 1033 files, which is 933 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 500 files.
|
2f56e62 to
76d90cb
Compare
|
Request: Shared-core review (Platform PO)
|
76d90cb to
204e3fd
Compare
… runtime to ludy_* (#3970)
204e3fd to
2176ba2
Compare
Shared-core review (stand-in)Over 4 hours have elapsed since the initial Files audited (24):
Scope check via Verdict: PASS (
Non-blocking follow-up noted for |
Closes #3970
Parent: #1682
Summary
Cuts over core internal database schemas, roles, GUCs, event triggers, notification channels, and runtime code from
crove_*/crove.*toludy_*/ludy.*per ADR-0054 (docs/plan/brand-phase3-identifiers.md), preserving one-waycrove_<r> -> ludy_<r>role inheritance and compatibility fallbacks during the#3970 -> #3972rollout window:supabase/migrations/20270315080000_ludy_kernel_rebrand_core_schemas_roles_gucs.sql):ludy_*core roles (ludy_tenant,ludy_app,ludy_worker,ludy_prober,ludy_reporter,ludy_auth_reader,ludy_definer_tenant,ludy_definer_einvoice,ludy_definer_system), grants one-wayludy_<r> -> crove_<r> WITH INHERIT TRUEfor runtime/definer roles while keepingcrove_proberandcrove_reporterstrictlyNOINHERITand membership-free, and keepsludy_*runtime roles free ofTEMPORARYin owned databases.ddl_watch()andagent_write_guard()before renamingcrove_kernel -> ludy_kernel,crove_meta -> ludy_meta,crove_jobs -> ludy_jobs.crove_definer_tenant,crove_definer_einvoice,crove_auth_reader->ludy_*) ahead of ACL transfer (scoping temporaryCREATEstrictly to the block), copies columnattaclahead of table/viewrelacl, copies grants ontoludy_<r>while revoking redundant direct grants from inheritingcrove_<r>roles (preservingcrove_prober/crove_reporter), updatesludy_jobsdefault privileges toludy_worker, and retargets RLSTOclauses toludy_*.ddl_watch(),ludy_reporter/crove_reporter, andmember_has_permission()SET ROLE ludy_tenant/crove_tenant), rewrites parentpg_triggerTG_ARGVcore schema strings (tgparentid = 0), and updatesludy_kernel.{member_vy_table,mcp_member_table}.packages/db/src/generated/database.ts(282 tables, including#4414,#4428,#4416,#4455, and#4456),packages/db/src/migrate.ts(grants ledger access only to activetenantRole), and keepsapplication_name: options.applicationName ?? 'crove'inpackages/db/src/index.tsintentionally until#3972so basesealed-context.db.test.tsstays green.Acceptance
ludy_kernel,ludy_meta,ludy_jobs), roles (ludy_*), and GUCs (ludy.*) are now canonical while legacycrove_*logins keep inheriting access and existingcrove_<module>schemas / public API contracts stay unchanged until#3971/#3972.2176ba29bee9b12a5ef7f8f7fe60b441f862fa92(clean rebase ontoorigin/maine626e250epreserving#4416,#4435,#4452,#4453,#4455, and#4456; all 24 shared-core/protected files have a byte-identical diff to76d90cb5e0c0e14d54dab9487f995af629921616and204e3fd1665ce0466fca720830eebfd25227b035, 211,196 bytes unchanged).2176ba29b(base: e626e250e):node tools/ci/migration-order.mjs origin/mainOK (1 new file above20270315075000),oxlint0w/0e across the 6 touched HR/Sign files,@ludy/{mod-hr,mod-sign,kernel-server}typecheckexit 0, and local PG17 DB suite 3/3 files, 6/6 tests passed (0 skipped):apps/kernel/test/invariant/sign-meeting-minutes-visibility.db.test.ts(2/2),modules/hr/test/hr-self-service-portal.db.test.ts(2/2),apps/kernel/test/sign-vault.db.test.ts(2/2).204e3fd16(identical 24 shared-core files): 33/33 checks green (0 failing, 0 cancelled, 2 skipped), including all 4 Database test shards, heavy DB files,Invariant suite (from base), shared-DB invariants, Playwright E2E shards + AI stack,CodeQL, andgitleaks.76d90cb5e,204e3fd16):projects-private+migrate+conformance+mcp-scope+projects-today+projects-private-flows(6/6 files, 58/58),pgtap-gate(21/21),vy-permission(8/8),member-vy-private(19/19),verify-3970-b2-b3.mjs(PASS), Batch R1 (6/6, 20/20), Batch R2 (9/9, 1669/1669), 13/13 ACL tests (74/74), 11/11 historical tests (95/95), 9/9 pre-cutover upgrade tests (46/46), unit suites (91/91).2176ba29bee9b12a5ef7f8f7fe60b441f862fa92: running (merge awaits full green).researchsubagent93e8aa34-9f2b-48ad-8383-dab7cb6ee929): PASS (blocking findings B1-B5 resolved and regression-tested; shared-core diff unchanged across rebase ontoe626e250e).researchsubagentd2f544b7-4a13-4cc3-8fe7-fb53b6d397d6, comment): PASS across all 24 protected/shared-core files after >4h without Platform PO reply since2026-11-22T10:30:39Z(Platform PO to review post-merge within 24h perdocs/product-owner-config.md).e626e250ekeeping#4455HR erasure/leave transition guards and#4456Contract Vault Q&A withludy_kernel/ludy_*identifiers; Section 3/4 ordering,attacl-before-relacl,tgparentid = 0,pg_default_aclcleanup,migrate.tsledger grant, B5 dual-role rewrite verified).SET ROLE crove_tenantbypass closed; T17hardeningViolationsclean;NOINHERITpreserved oncrove_prober/crove_reporter; definer ownership transferred with temporaryCREATErevoked;#4416/#4455/#4456access boundaries intact).org_idscoping, RLSTO ludy_tenantpolicy rewrites,crove_tenant -> ludy_tenantinheritance,sign-meeting-minutes-visibility2/2,projects-private6/6, andrls-matrixverified).lock_timeout = '2s'and 15-attempt retry loops with jitter on policy/trigger rewrites;tgparentid = 0avoids child partition trigger churn;#4416innerJoinLateralpreserved).#4435E2E test core SQL aligned toludy_kernel).crove_*compatibility roles andapplication_name = 'crove'stay active until#3972cleanup (#3972should also revokecrove_tenantfrompg_type.typaclon the 4 finance domains before droppingcrove_tenant);auth-grantsmust run immediately aftermigrateon upgrade deploys per the existing deployment contract.