Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/web/src/app/(public)/donations/[code]/page.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ describe("DonationPage (/donations/[code], DOS/Give#50)", () => {
expect(html).toContain("Bữa trưa cho em")
expect(html).toContain("GVABCDEFG")
expect(html).toContain("Đã nhận")
expect(html).toContain("Tải thẻ “Tôi đã chung tay”")
expect(html).toContain("Sao chép đường dẫn")
expect(html).toContain("Lưu đường dẫn theo dõi")
// Neither the SSR DOM attributes/text nor the DB select list exposes personal data or raw token.
Expand Down Expand Up @@ -247,5 +248,16 @@ describe("DonationPage for a monthly plan's donation (DOS/Give#276)", () => {

expect(html).toContain("Chiến dịch hiện không nhận chuyển khoản")
expect(html).not.toContain("0123456789")
expect(html).not.toContain("Tải thẻ “Tôi đã chung tay”")
})

it("hides the thank-you card button while awaiting transfer and shows it once received (DOS/Give#313)", async () => {
setUp(ownRow({ status: "awaiting_transfer", received_amount: 0 }))
const awaitingHtml = await render()
expect(awaitingHtml).not.toContain("Tải thẻ “Tôi đã chung tay”")

setUp(ownRow({ status: "received", received_amount: 200000, public_name: "Nguyễn Minh", is_anonymous: false }))
const receivedHtml = await render()
expect(receivedHtml).toContain("Tải thẻ “Tôi đã chung tay”")
})
})
32 changes: 24 additions & 8 deletions apps/web/src/app/(public)/donations/[code]/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { Money } from "@/components/ui/Money"
import { RefCode } from "@/components/ui/RefCode"
import { siteOrigin } from "@/lib/auth/origin"
import { getSession } from "@/lib/auth/session"
import { isPublicStatus, type CampaignStatus } from "@/lib/campaigns"
import { donationTrackingPath, qrExpiresAt } from "@/lib/contributions"
import { NEW_CODE_EVERY_MONTH, periodEnd, periodLabel, planDonationPayable, planQrUntil } from "@/lib/plans"
import { dbAs, dbService } from "@/lib/supabase"
Expand Down Expand Up @@ -65,29 +66,31 @@ function planQrCaption(until: Date, period: string): string {
* back; anyone else gets the not-found page, which explains where the page
* can be opened.
*/
async function loadDonation(code: string): Promise<{ donation: PaymentContribution; guestToken: string | null }> {
async function loadDonation(
code: string
): Promise<{ donation: PaymentContribution; guestToken: string | null; donorDisplayName: string | null }> {
const session = await getSession()
let sessionRejected = false
if (session) {
try {
const own = await ownContribution(dbAs(session.accessToken), session.user.id, code)
if (own) return { donation: own, guestToken: null }
if (own) return { donation: own, guestToken: null, donorDisplayName: session.user.name ?? null }
} catch (error) {
if (!isSessionRejected(error)) throw error
sessionRejected = true
}
}
const token = donationCookieToken(await cookies(), code, hostnameFrom((await headers()).get("host")))
const guest = token ? await guestContribution(dbService(), code, token) : null
if (guest && token) return { donation: guest, guestToken: token }
if (guest && token) return { donation: guest, guestToken: token, donorDisplayName: null }
if (sessionRejected) redirect(`/auth/login?return_path=${encodeURIComponent(`/donations/${code}`)}`)
notFound()
}

export default async function DonationPage({ params }: { params: Promise<{ code: string }> }) {
const { code } = await params
if (!isDonationCode(code)) notFound()
const { donation, guestToken } = await loadDonation(code)
const { donation, guestToken, donorDisplayName } = await loadDonation(code)

const service = dbService()
const campaign = await paymentCampaign(service, donation.campaign_id)
Expand Down Expand Up @@ -180,6 +183,21 @@ export default async function DonationPage({ params }: { params: Promise<{ code:
instructions = closedNote
}

const origin = siteOrigin()
const thankYou = isPublicStatus(campaign.status as CampaignStatus)
? {
kind: "donation" as const,
campaignTitle: campaign.title,
campaignSlug: campaign.slug,
campaignType: campaign.type,
// Guest tracking views never expose donor PII; signed-in owners respect anonymity.
donorName: guestToken ? null : donation.is_anonymous ? null : donation.public_name?.trim() || donorDisplayName,
isAnonymous: guestToken ? false : donation.is_anonymous === true,
createdAt: donation.created_at,
origin,
}
: null

return (
<div className="container-page pt-6 pb-16 sm:pt-8 lg:pb-24">
<header className="min-w-0">
Expand Down Expand Up @@ -227,10 +245,7 @@ export default async function DonationPage({ params }: { params: Promise<{ code:
Lưu đường dẫn theo dõi để xem trạng thái khoản ủng hộ này trên thiết bị khác trong 7 ngày. Đường dẫn
không chứa thông tin cá nhân.
</p>
<TrackingLinkButton
path={donationTrackingPath(donation.reference_code, guestToken)}
origin={siteOrigin()}
/>
<TrackingLinkButton path={donationTrackingPath(donation.reference_code, guestToken)} origin={origin} />
</div>
)}
</aside>
Expand All @@ -241,6 +256,7 @@ export default async function DonationPage({ params }: { params: Promise<{ code:
qrExpired={qrExpired}
qrMsLeft={expiresAt ? Math.max(0, expiresAt.getTime() - now.getTime()) : 0}
expiredNote={expiredNote}
thankYou={thankYou}
>
{instructions}
</DonationStatus>
Expand Down
149 changes: 149 additions & 0 deletions apps/web/src/app/campaigns/[slug]/opengraph-image.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
import { beforeEach, describe, expect, it, vi } from "vitest"

import type { CampaignStatus, PublicCampaign } from "@/lib/campaigns"
import { PUBLIC_COVER_CACHE } from "@/lib/cover-route"
import { fakeDb, type Call, type Handler } from "@/test/fake-db"

const CAMPAIGN = "33333333-3333-4333-8333-333333333333"
const SLUG = "xay-truong-ban-may"

const state = vi.hoisted(() => ({
anonHandler: (() => undefined) as Handler,
anonCalls: [] as Call[],
dbAsTokens: [] as (string | undefined)[],
}))

vi.mock("@/lib/supabase", () => ({
dbAs: (token?: string) => {
state.dbAsTokens.push(token)
return fakeDb((call) => state.anonHandler(call), state.anonCalls)
},
}))

const { default: CampaignOpenGraphImage, contentType, size } = await import("./opengraph-image")

function campaignFixture(status: CampaignStatus = "live", overrides: Partial<PublicCampaign> = {}): PublicCampaign {
return {
id: CAMPAIGN,
slug: SLUG,
type: "give",
funding_model: "flexible",
category_id: "cat-1",
title: "Xây trường Bản Mây — Hỗ trợ bữa ăn đủ chất cho trẻ em vùng cao",
summary: "Cùng dựng lớp học mới.",
story: null,
beneficiary_name: null,
beneficiary_relation: null,
cover_media_id: null,
asset: "VND",
goal_amount: 100_000_000,
min_contribution: 20_000,
stretch_goal_amount: null,
display_options: { progress_bar: true, backers_count: true, time_remaining: true },
starts_at: null,
ends_at: "2099-12-31T00:00:00.000Z",
payment_window_days: 7,
status,
submitted_at: "2026-11-10T00:00:00.000Z",
approved_at: "2026-11-11T00:00:00.000Z",
outcome_at: null,
created_at: "2026-11-01T00:00:00.000Z",
updated_at: "2026-11-11T00:00:00.000Z",
category: { id: "cat-1", slug: "giao-duc", name: "Giáo dục", icon: null, color: null },
cover: null,
...overrides,
}
}

beforeEach(() => {
state.anonCalls.length = 0
state.dbAsTokens.length = 0
state.anonHandler = (call) => {
if (call.target === "campaigns") return { data: campaignFixture("live") }
if (call.target === "public_campaigns") {
return {
data: {
id: CAMPAIGN,
type: "give",
asset: "VND",
goal_amount: 100_000_000,
pledged_amount: 0,
paid_amount: 45_000_000,
disbursable_amount: 45_000_000,
disbursed_amount: 0,
refunded_amount: 0,
unexplained_out_amount: 0,
unexplained_out_count: 0,
supporters_count: 18,
other_in_amount: 5_000_000,
refund_owed_amount: 0,
backers_count: 0,
payments_stopped_at: null,
payments_stopped_note: null,
own_transfer_amount: 0,
},
}
}
if (call.target === "rpc:public_organizer") {
return { data: [{ display_name: "Quỹ Bản Mây", kind: "organization", verification_status: "verified" }] }
}
return undefined
}
})

describe("CampaignOpenGraphImage (/campaigns/[slug]/opengraph-image, DOS/Give#313)", () => {
it("declares standard 1200x630 PNG metadata", () => {
expect(size).toEqual({ width: 1200, height: 630 })
expect(contentType).toBe("image/png")
})

it("renders a valid PNG with bundled Vietnamese font and public cache headers for public give and back campaigns", async () => {
const giveResponse = await CampaignOpenGraphImage({ params: Promise.resolve({ slug: SLUG }) })
expect(giveResponse.status).toBe(200)
expect(giveResponse.headers.get("content-type")).toContain("image/png")
expect(giveResponse.headers.get("cache-control")).toBe(PUBLIC_COVER_CACHE)
expect(giveResponse.headers.get("x-content-type-options")).toBe("nosniff")
// Anonymous dbAs() only — never reads authenticated session.
expect(state.dbAsTokens).toEqual([undefined])

const bytes = new Uint8Array(await giveResponse.arrayBuffer())
expect(bytes.length).toBeGreaterThan(1000)
// PNG magic header: 89 50 4E 47 0D 0A 1A 0A
expect(Array.from(bytes.slice(0, 8))).toEqual([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a])

// Also renders cleanly for a succeeded back campaign.
const base = state.anonHandler
state.anonHandler = (call) =>
call.target === "campaigns"
? { data: campaignFixture("succeeded", { type: "back", funding_model: "all_or_nothing" }) }
: base(call)
const backResponse = await CampaignOpenGraphImage({ params: Promise.resolve({ slug: SLUG }) })
expect(backResponse.status).toBe(200)
const backBytes = new Uint8Array(await backResponse.arrayBuffer())
expect(Array.from(backBytes.slice(0, 4))).toEqual([0x89, 0x50, 0x4e, 0x47])
})

it.each(["draft", "in_review", "changes_requested", "approved", "suspended", "cancelled"] as const)(
"strictly returns 404 with no-store for non-public campaign status %s",
async (status) => {
state.anonHandler = (call) => (call.target === "campaigns" ? { data: campaignFixture(status) } : undefined)

const response = await CampaignOpenGraphImage({ params: Promise.resolve({ slug: SLUG }) })
expect(response.status).toBe(404)
expect(response.headers.get("cache-control")).toBe("no-store")
}
)

it("returns 404 for nonexistent campaigns and invalid slugs without querying the database for invalid slugs", async () => {
state.anonHandler = () => ({ data: null })
const missing = await CampaignOpenGraphImage({ params: Promise.resolve({ slug: SLUG }) })
expect(missing.status).toBe(404)
expect(missing.headers.get("cache-control")).toBe("no-store")

state.anonCalls.length = 0
const invalid = await CampaignOpenGraphImage({ params: Promise.resolve({ slug: "BAD SLUG/.." }) })
expect(invalid.status).toBe(404)
expect(invalid.headers.get("cache-control")).toBe("no-store")
expect(state.anonCalls).toHaveLength(0)
})
})
Loading