Skip to content

docs(changelog): sync CHANGELOG.md for Wave 2 (#273, #77, #291, #308, #92, #303) - #311

Merged
JOY (JOY) merged 1 commit into
devfrom
antigravity/give-wave2-changelog
Nov 22, 2026
Merged

JOY (JOY) merged 1 commit into
devfrom
antigravity/give-wave2-changelog

Conversation

@JOY

@JOY JOY (JOY) commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Syncs CHANGELOG.md on dev for the Wave 2 deliverables ahead of Production promotion (matching commit c5956769 / PR #300 conventions):

Verification

  • pnpm format:check — PASS
  • pnpm lint — PASS

📌 TL;DR

This PR implements finance-approved receiving-account swaps for back campaigns and monthly plan donors, including masked email notifications and strict PII protection. It also hardens the email outbox infrastructure, adds atomic status guards for campaign recovery, and updates Product Owner configuration policies.

🎯 Type of Change

  • 🚀 New feature
  • 🐛 Bugfix
  • 🧹 Refactor
  • ⚡ Performance
  • 📚 Documentation
  • ⚙️ CI / Configuration

🔍 Changes Walkthrough

File Summary of Changes
CHANGELOG.md Documents new features for back-campaign account swaps, monthly plan donor notifications, email outbox hardening, and PO configuration updates.
apps/web/src/server/contributions/index.ts Adds paymentAccounts() helper with bounded concurrency (max 5) and per-campaign error isolation; skips RPCs for ended plans.
apps/web/src/server/plans/jobs.ts Hardens cron jobs to isolate steps within a 45s budget, drains multi-batch expirations with error isolation, and emits structured zero-PII JSON error logs.
apps/web/src/server/email/templates.ts Adds pledge_account_swapped and plan_account_swapped email templates with masked account details and specific CTA links.
apps/web/src/lib/email-outbox.ts Updates outbox metadata labels, skip reasons, and max age (14 days) for new notification types.
apps/web/src/server/email/outbox.ts Increases CLAIM_TIMEOUT_MS to 15s and improves abort signal handling to detect committed leases after timeouts.
apps/web/src/server/email/provider.ts Hardens usesProductionDatabase to inspect JWT ref claims in Supabase keys, ignoring opaque or malformed tokens.
docs/product-owner-config.md Updates PO authority to any (Antigravity/Claude), records JOY's takeover, and documents the local DB ban policy.
lib/notices.ts Adds payment_account_changed in-app notice and wires it into asksForPayment to suppress payment CTAs when stopped.
lib/plans.ts Shares currentPlanDonation() and vnMonthStart logic to optimize contribution page loads.
lib/errors.ts Extends error handling to support new account swap and recovery scenarios.
server/email/templates.ts (Likely duplicate or specific server-side template path) Defines transactional email structures for account swaps.
apps/web/src/me/campaigns/[id] Updates ReceivingAccountSection and AccountSwapBlock to support finance-approved swaps for back campaigns.
apps/web/src/admin/account-swaps Extends admin UI to handle new swap approval flows and recovery advice.
give.request_account_swap (DB) Extends swap logic to back campaigns in live, suspended, changes_requested, and succeeded states.
give.transition_campaign (DB) Adds p_expected_status guard for atomic status transitions and allows moderator recovery for never-live campaigns.
give.campaigns_needing_recovery (DB) New function to list campaigns requiring recovery (approved_past_end, suspended_before_start).
give.outbox_on_account_swap (DB) New trigger to enqueue masked, zero-PII notification rows for active plan donors upon account swap.
give.claim_outbox (DB) Adds send-time re-checks (e.g., plan_not_active, account_superseded) and mints fresh stop tokens.
give.purge_outbox (DB) Adds FOR UPDATE SKIP LOCKED batching, protects in-flight sends, and caps hold times for payment reminders.
20261130140000_give_back_campaign_account_swap Migration for back-campaign swap logic and payment_due notices.
20261130130000_give_plan_account_swap_notice Migration for monthly plan donor swap notifications.
20261130120000_give_campaign_sendback_and_suspended_recovery Migration for atomic status guards and recovery queue.
20261130110000_give_outbox_followups Migration for outbox performance indexes and purge logic improvements.

📊 Architectural Flow

sequenceDiagram
    participant Admin as Admin/Finance
    participant Web as Web App (Next.js)
    participant DB as PostgreSQL (DOS.Me)
    participant Outbox as Email Outbox
    participant Email as Email Provider

    Admin->>Web: Approve Account Swap
    Web->>DB: Call give.decide_account_swap
    DB->>DB: Update campaign account
    DB->>DB: Trigger give.outbox_on_account_swap
    DB->>Outbox: Enqueue masked notification rows (plan_account_swapped / pledge_account_swapped)
    
    Note over Outbox: Cron Job / Claim Process
    Outbox->>DB: Claim outbox rows (FOR UPDATE SKIP LOCKED)
    DB->>Outbox: Return rows with fresh stop tokens
    Outbox->>Outbox: Re-check status (plan_not_active, account_superseded)
    Outbox->>Email: Send masked email (last 4 digits only)
    Email-->>Donor: Notification with CTA to update payment info
Loading

@JOY JOY (JOY) added the po:agy Owned by Antigravity PO (mutual-exclusion parallel PO label) label Nov 22, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization has no extra usage available to pay for this review.

If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.

Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.

@vercel

vercel Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
give Ready Ready Preview Nov 22, 2026 12:26pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3628f619-0ede-4d9a-814e-3173c1eee702

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

dos[bot]
dos Bot approved these changes Nov 22, 2026

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (1 eligible files · 10,683 chars · 1 model call(s) · 1 PR unit(s))

Whole diff with bounded context at base 581915e / head 38262c5.

✅ CLEAN_PASS: Complete diff reviewed

@JOY

Copy link
Copy Markdown
Contributor Author

PO acceptance: merge at 38262c5

Reviewed full CHANGELOG.md diff directly: accurate Wave 2 entries (#273/#305, #77/#306, #291/#307, #308/#309, #92/#310, #303/#304) and all 4 DOS.Me migrations (#1870-#1873). Required CI checks green, mergeStateStatus CLEAN.

@JOY
JOY (JOY) merged commit cb46d9b into dev Nov 22, 2026
6 checks passed
@JOY
JOY (JOY) deleted the antigravity/give-wave2-changelog branch November 22, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

po:agy Owned by Antigravity PO (mutual-exclusion parallel PO label)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant