Skip to content

Follow-ups from the #64 reviews (send-back race, suspended-before-start recovery) #77

Closed

Description

@JOY

Deferred from the review rounds of #75 and DOS/DOS.Me#1515 (#64), round 3 and later P2/P3 per the review rules.

  • P3 apps/web/src/app/admin/actions.ts requestChanges: the app reads the status, then calls transition_campaign; another moderator can still approve in the gap between them (very narrow). A full fix is an expected-from-status argument on give.transition_campaign (DOS.Me migration). The same status read maps any read error to the "not found" message.
  • P3 (product, related to Replace a disabled receiving account on a live give campaign #55): a give campaign suspended before its start (never live, so no donations) whose receiving account becomes unusable is stuck: suspended -> approved needs a usable account and there is no suspended -> changes_requested, so a moderator can only cancel it. Either cover it in Replace a disabled receiving account on a live give campaign #55 or add a reviewer suspended -> changes_requested when starts_at > now().
  • P3 apps/web/src/lib/campaign-account.ts openingBlock: a binding to an account the organizer does not own reads as "no account" in the editor (boundAccountOf searches only own accounts). Data-defect only (bind_receiving_account requires the owner); the notice now says to contact Give if binding fails.
  • Note: an approved give campaign past its end date whose account is usable never opens and is in no admin queue (the Recover a give campaign whose receiving account becomes unusable after approval #64 queue lists only campaigns without a usable account).
  • P3 apps/web/src/lib/campaign-account.ts submitUnusableAccount: a give campaign sent back with an account that recorded a transaction is told to release it on resubmit, which the DB refuses (GIVE_BINDING_NOT_RELEASABLE); the review note gives the right guidance. Word the refusal differently when the binding has transactions.

Activity

  1. added theissue type on Nov 14, 2026
  2. JOY commented on Nov 14, 2026

    @JOY
    ContributorAuthor

    claim: executor="Claude Code" session=qwen-20261114T1000-0077 scope="apps/web/src/lib/campaign-account.ts, apps/web/src/app/me/campaigns, apps/web/src/app/admin/actions.ts" branch=qwen/77-campaign-account-admin-followups target=2026-11-14

  3. JOY commented on Nov 14, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=qwen-20261114T1000-0077Opened PR #190 into dev covering the apps/web (line:campaigns) items of #77 (82 Vitest files / 1,036 tests green, pnpm format:check && pnpm lint && pnpm typecheck && pnpm test && pnpm build passed). Remaining DOS/DOS.Me migration items stay open on #77 for line:platform handoff after merge.

  4. JOY commented on Nov 14, 2026

    @JOY
    ContributorAuthor

    release: session=qwen-20261114T1000-0077 reason="taken over by real sub-session Give-a1-a19962: moved from subagent to sub-session"

  5. JOY commented on Nov 14, 2026

    @JOY
    ContributorAuthor

    claim: executor="Claude Code" session=Give-a1-a19962 scope="apps/web/src/lib/campaign-account.ts, apps/web/src/app/me/campaigns, apps/web/src/app/admin/actions.ts" branch=qwen/77-campaign-account-admin-followups target=2026-11-14

  6. JOY commented on Nov 14, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=Give-a1-a19962
    PR #190 (qwen/77-campaign-account-admin-followups -> dev, head 4d595b4afe33c41c63d5e034c8b8814f35683def, mergeStateStatus: CLEAN) is ready for Campaigns PO acceptance:

    • Changes (apps/web / line:campaigns scope of Follow-ups from the #64 reviews (send-back race, suspended-before-start recovery) #77):
      1. apps/web/src/app/admin/actions.ts (approveCampaign, requestChanges): distinguishes failed campaigns .maybeSingle() pre-reads (readError) from absent rows (GIVE_CAMPAIGN_NOT_FOUND).
      2. apps/web/src/lib/campaign-account.ts, apps/web/src/app/me/campaigns/actions.ts, apps/web/src/app/me/campaigns/[id]/page.tsx: loads bindingHasTransactions across editable statuses (draft and changes_requested) with .catch(() => canAskSwap(status, type, true)), hides guaranteed-to-fail "Nhả tài khoản" when isEditableStatus(status) && boundHasTransactions, and gates swap guidance on canAskSwap (changes_requested + give -> swap flow; draft or back with transactions -> contact Give).
      3. apps/web/src/lib/campaign-account.ts (openingBlock): documents and tests the non-owned binding "no_account" fallback.
      4. Added unit + RSC render coverage (campaign-account.test.ts, me/campaigns/actions.test.ts, me/campaigns/[id]/page.test.ts, admin/actions.test.ts) and updated CHANGELOG.md.
    • Verification & Reviews on 4d595b4afe33c41c63d5e034c8b8814f35683def:
      • pnpm format:check, pnpm lint, pnpm typecheck, vitest run (83 files / 1,041 tests), and pnpm build passed.
      • codex review -c model_reasoning_effort=high --base origin/dev: PASS (0 findings).
      • Fresh-context read-only subagent review: PASS (0 findings).
      • Required GitHub checks (Lint, Build all apps) + DOS Code Review (CLEAN_PASS) + Vercel all SUCCESS; 0 unresolved review threads.
    • Next step: Waiting on Campaigns PO acceptance ("merge") before squash-merging PR Follow-ups from #64 in apps/web: requestChanges read error, submit swap guidance, tests (#77) #190 and posting handoff: to "Claude Code" (Give Product Owner) for the remaining DOS/DOS.Me SQL items on Follow-ups from the #64 reviews (send-back race, suspended-before-start recovery) #77.
  7. JOY commented on Nov 15, 2026

    @JOY
    ContributorAuthor

    release: session=Give-a1-a19962 reason="taken over by Give-1a-1aa053: rebase PR #190 onto latest dev after #192/#191 and finish acceptance"

  8. JOY commented on Nov 15, 2026

    @JOY
    ContributorAuthor

    claim: executor="Claude Code" session=Give-1a-1aa053 scope="apps/web/src/lib/campaign-account.ts, apps/web/src/app/me/campaigns, apps/web/src/app/admin/actions.ts" branch=qwen/77-campaign-account-admin-followups target=2026-11-15

  9. added 2 commits that reference this issue on Nov 15, 2026
  10. JOY commented on Nov 15, 2026

    @JOY
    ContributorAuthor

    release: session=Give-1a-1aa053 reason="taken over by Give-d2-d255ef: rebase PR #190 onto latest dev"

  11. JOY commented on Nov 15, 2026

    @JOY
    ContributorAuthor

    claim: executor="Claude Code" session=Give-d2-d255ef scope="apps/web/src/lib/campaign-account.ts, apps/web/src/app/me/campaigns, apps/web/src/app/admin/actions.ts" branch=qwen/77-campaign-account-admin-followups target=2026-11-15

  12. 8 remaining items

  13. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=bb1d536b-6d46-41b9-bc70-eb2668945c2b
    Opened Phase 1 DB PR https://github.com/DOS/DOS.Me/pull/1872 (antigravity/give-77-sendback-suspended-recovery -> dev, head 7710cb6ced71845e0fdd09bb7abe27b3ac5bfd3a) adding 20261130120000_give_campaign_sendback_and_suspended_recovery.sql (p_expected_status CAS guard + suspended -> changes_requested before start + give.campaigns_needing_recovery()) and 62-test pgTAP suite give_campaign_sendback_recovery.test.sql. Waiting on required CI checks and fresh-context security review.

  14. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=bb1d536b-6d46-41b9-bc70-eb2668945c2b
    Phase 1 DB PR https://github.com/DOS/DOS.Me/pull/1872 (antigravity/give-77-sendback-suspended-recovery -> dev, head 7710cb6ced71845e0fdd09bb7abe27b3ac5bfd3a) is ready for PO acceptance:

    • All 4 required CI checks passed: Give pgTAP tests (dev), Supabase migration replay (dev), Repository integrity, Validate pnpm lockfile.
    • Reviews on 7710cb6ced71845e0fdd09bb7abe27b3ac5bfd3a: dos[bot] APPROVED (CLEAN_PASS), gemini-code-assist[bot] CLEAN_PASS (0 findings), fresh-context flagship security subagent (c8f78d8c-0e5e-41ab-a069-dd7219094013) CLEAN_PASS (0 findings); 0 unresolved threads.
    • Waiting on Give PO acceptance before merge into DOS/DOS.Me dev and Phase 2 DOS/Give app PR.
  15. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    PO acceptance: merge at 7710cb6ced71845e0fdd09bb7abe27b3ac5bfd3a (DOS/DOS.Me#1872 -> dev)

  16. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=bb1d536b-6d46-41b9-bc70-eb2668945c2b
    Phase 1 DB PR https://github.com/DOS/DOS.Me/pull/1872 squash-merged into DOS/DOS.Me dev at a280fcf01c2181c7a74ba6d3f5d79c88cbc8fa8b (accepted head 7710cb6ced71845e0fdd09bb7abe27b3ac5bfd3a); Beta sync Supabase Preview passed (check-run 137157543189, conclusion: success). DOS.Me worktree and branch cleaned up. Starting Phase 2 DOS/Give app PR on branch antigravity/give-77-sendback-suspended-recovery.

  17. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=bb1d536b-6d46-41b9-bc70-eb2668945c2b
    Phase 2 app PR #306 (antigravity/give-77-sendback-suspended-recovery -> dev, head 8a3421b218c583929460d7dc5d46bed43f33f247, mergeStateStatus: CLEAN) is ready for PO acceptance:

    • Local checks: pnpm format:check, pnpm lint, pnpm typecheck, pnpm test (180 Vitest files / 2,631 tests), pnpm build all passed.
    • GitHub checks on 8a3421b218c583929460d7dc5d46bed43f33f247: Lint, Build all apps, Vercel, Vercel Preview Comments, DOScout all SUCCESS.
    • Reviews: dos[bot] APPROVED (CLEAN_PASS), fresh-context independent reviewer (9e65e286-829c-422b-a970-6beb714b6ce0) round 1 found 2 P2 + 1 P3 in recoveryAdvice (all fixed in 8a3421b2) -> round 2 CLEAN_PASS; 0 unresolved threads.
    • Waiting on Give PO acceptance before squash-merging PR feat(admin): atomic expected-status guard and pre-launch recovery queue (#77) #306 into dev.
  18. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=bb1d536b-6d46-41b9-bc70-eb2668945c2b
    Both Phase 1 (DB) and Phase 2 (app) PRs for #77 are merged into dev and verified on Beta:

    • Phase 1 (DOS/DOS.Me): PR https://github.com/DOS/DOS.Me/pull/1872 squash-merged into dev at a280fcf01c2181c7a74ba6d3f5d79c88cbc8fa8b (20261130120000_give_campaign_sendback_and_suspended_recovery.sql); Beta Supabase Preview passed (check-run 137157543189, conclusion: success).
    • Phase 2 (DOS/Give): PR feat(admin): atomic expected-status guard and pre-launch recovery queue (#77) #306 squash-merged into dev at 9deab36a1e140c72a3d24cef11e39eb409479d41 (accepted head 8a3421b218c583929460d7dc5d46bed43f33f247); Vercel Beta deploy (https://beta.give.vn) completed with state: success (https://vercel.com/metados/give/ABspUg9EDAmzyB26qVrKzpRPGS2b); Build all apps (137162878903) and Lint (137162878799) success.
    • Both isolated worktrees and local branches cleaned up. Issue stays open for the next Production promotion (DOS/DOS.Me dev -> main, then DOS/Give dev -> main).
  19. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    handoff: session=bb1d536b-6d46-41b9-bc70-eb2668945c2b to=83b36fa6-8c08-49d6-aeec-63bab02a5e52

    Done: Squash-merged Phase 1 DB PR https://github.com/DOS/DOS.Me/pull/1872 into DOS/DOS.Me dev at a280fcf01c2181c7a74ba6d3f5d79c88cbc8fa8b (20261130120000_give_campaign_sendback_and_suspended_recovery.sql + 62-test pgTAP suite give_campaign_sendback_recovery.test.sql + 6 updated pgTAP suites) and Phase 2 app PR #306 into DOS/Give dev at 9deab36a1e140c72a3d24cef11e39eb409479d41 (atomic p_expected_status guards in approveCampaign/requestChanges, GIVE_CAMPAIGN_STATUS_CHANGED & SUSPENDED_SEND_BACK_MESSAGES, /admin #recovery section wired to give.campaigns_needing_recovery(), CHANGELOG.md, and unit/RSC Vitest coverage). Removed both local worktrees and branches.
    Evidence:

    • DOS/DOS.Me#1872 (head 7710cb6ced71845e0fdd09bb7abe27b3ac5bfd3a, merged a280fcf01c2181c7a74ba6d3f5d79c88cbc8fa8b): Give pgTAP tests (dev), Supabase migration replay (dev), Repository integrity, Validate pnpm lockfile, dos[bot] APPROVED, gemini-code-assist[bot] CLEAN_PASS, fresh-context security reviewer CLEAN_PASS, PO acceptance, and Beta Supabase Preview (check-run 137157543189, success).
    • DOS/Give#306 (head 8a3421b218c583929460d7dc5d46bed43f33f247, merged 9deab36a1e140c72a3d24cef11e39eb409479d41): pnpm format:check, pnpm lint, pnpm typecheck, pnpm test (180 Vitest files / 2,631 tests), pnpm build, GitHub Lint (137162878799), Build all apps (137162878903), dos[bot] APPROVED, fresh-context reviewer round 2 CLEAN_PASS, PO acceptance, and Vercel Beta deploy (https://beta.give.vn, https://vercel.com/metados/give/ABspUg9EDAmzyB26qVrKzpRPGS2b, state: success).
      Remaining: Production promotion (DOS/DOS.Me dev -> main first so migration 20261130120000 is live on Production, then DOS/Give dev -> main), Production verification, and posting done: to close Follow-ups from the #64 reviews (send-back race, suspended-before-start recovery) #77.
      Next step: Give PO (83b36fa6-8c08-49d6-aeec-63bab02a5e52) includes DOS/DOS.Me#1872 (a280fcf01c2181c7a74ba6d3f5d79c88cbc8fa8b) and DOS/Give#306 (9deab36a1e140c72a3d24cef11e39eb409479d41) in the next owner-approved Production promotion.
      Blockers: Owner approval for Production promotion (dev -> main).
      Branch: antigravity/give-77-sendback-suspended-recovery, squash-merged into DOS/DOS.Me dev at a280fcf01c2181c7a74ba6d3f5d79c88cbc8fa8b and DOS/Give dev at 9deab36a1e140c72a3d24cef11e39eb409479d41.
  20. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    claim: executor=Antigravity session=83b36fa6-8c08-49d6-aeec-63bab02a5e52 scope="Production steps, waiting for next Production promotion (DOS/DOS.Me#1872 + #306 -> main)" branch=antigravity/give-77-sendback-suspended-recovery target=2026-11-29

  21. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=83b36fa6-8c08-49d6-aeec-63bab02a5e52 waiting for next Production promotion (dev -> main after JOY approval); Phase 1 DOS/DOS.Me#1872 merged at a280fcf01c2181c7a74ba6d3f5d79c88cbc8fa8b (Supabase Preview Beta success) and Phase 2 #306 merged at 9deab36 (Vercel https://beta.give.vn success).

  22. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    done: session=83b36fa6-8c08-49d6-aeec-63bab02a5e52 agent=antigravity
    Promoted to Production (2026-11-22):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    line:campaignsProduct line: campaignspo:agyOwned by Antigravity PO (mutual-exclusion parallel PO label)

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions