Skip to content

Monthly donations A (#290) P3 follow-ups: batch payment_account lookup, doc comment, expiry batch isolation, cron failed-outcome alert #308

Closed

Description

@JOY

Goal

Batch the 4 non-blocking P3 follow-ups recorded from DOS/Give#290 (#276 Monthly donations A) into one clean cleanup PR into dev:

Requirements

  • Per-campaign payment_account N+1 lookup: Batch the payment_account RPC/lookup on /me/contributions (or wherever monthly plan rows fetch campaign payment accounts per row) to eliminate N+1 DB calls when a user has multiple plans.
  • Misplaced doc comment: Clean up the misplaced doc comment in apps/web/src/app/me/contributions/page.tsx.
  • Expiry stuck on one bad batch: Ensure monthly plan expiry/job processing isolates a failing/malformed batch or row so one bad item cannot permanently stall subsequent eligible plans.
  • Cron alert on 'failed' outcomes: Emit structured warning/error logging (zero PII) when monthly plan cron jobs return 'failed' outcomes so Vercel logs/alerts surface failures cleanly.

Acceptance

  • All 4 items above resolved cleanly with targeted unit tests.
  • Zero changes to DB schema/migrations (app-only apps/web cleanup) and zero PII logged.
  • pnpm format:check, pnpm lint, pnpm typecheck, pnpm test, pnpm build, required CI checks (Lint, Build all apps), and fresh-context independent review pass.

Files

  • apps/web/src/app/me/contributions/page.tsx
  • apps/web/src/server/plans/*
  • apps/web/src/app/api/cron/* (monthly plan routes)
  • Corresponding unit test files

Activity

  1. added
    po:agyOwned by Antigravity PO (mutual-exclusion parallel PO label)
    on Nov 22, 2026
  2. added theissue type on Nov 22, 2026
  3. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    claim: executor=Antigravity session=8dd7248e-6eeb-4bdf-ae4d-d3a6576fc677 scope="apps/web #308 monthly donations A (#290) P3 follow-ups" branch=antigravity/308-monthly-plan-p3-followups target=2026-11-23

  4. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=8dd7248e-6eeb-4bdf-ae4d-d3a6576fc677 PR opened: #309 (head a80257d) into dev. Local verification clean (format:check, lint, typecheck, 180 files / 2,650 tests, build) and independent fresh-context review PASS (0 P0-P3 remaining). Waiting on required CI checks (Lint, Build all apps) before PO acceptance.

  5. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=8dd7248e-6eeb-4bdf-ae4d-d3a6576fc677 PR #309 squashed and merged into dev at dd40557 (after PO acceptance + flagship money-domain review APPROVE + independent fresh-context review PASS + dos[bot] CLEAN_PASS + required CI Lint / Build all apps green). Vercel dev/beta deployment on dd40557 succeeded (https://vercel.com/metados/give/2mWeq7jy3YFHLdoLVZsM1RucHMZU). Worktree and local branch removed. Keeping #308 open pending Production promotion to main.

  6. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    handoff: session=8dd7248e-6eeb-4bdf-ae4d-d3a6576fc677 to=83b36fa6-8c08-49d6-aeec-63bab02a5e52

    Done: All 4 app-only P3 follow-ups from #290 implemented and merged into dev via #309 (head a80257d90ef49976da73a43239654422569fbf25, squash merge commit dd405579004ea9219fefd177d0ba145c0f39f2be). Worktree /Users/JOY/Projects/Give-worktrees/308-monthly-plan-p3-followups and local branch antigravity/308-monthly-plan-p3-followups removed.
    Evidence: Local pnpm format:check, pnpm lint, pnpm typecheck, vitest run --maxWorkers=2 (180 files / 2,650 tests), pnpm build all green; independent fresh-context review PASS (0 P0–P3 remaining); PO flagship money-domain review APPROVE (0 findings); dos[bot] CLEAN_PASS; required CI (Lint, Build all apps) green; Vercel dev/beta deploy succeeded on dd405579004ea9219fefd177d0ba145c0f39f2be (https://vercel.com/metados/give/2mWeq7jy3YFHLdoLVZsM1RucHMZU).
    Remaining: Promote dev (including dd405579004ea9219fefd177d0ba145c0f39f2be) to Production main in the next owner-approved Production release, verify on https://give.vn, and close #308 with done:.
    Next step: Include dd405579004ea9219fefd177d0ba145c0f39f2be in the next dev -> main Production promotion batch once JOY approves.
    Blockers: none (app-only, zero DB migrations).
    Branch: merged into dev at dd405579004ea9219fefd177d0ba145c0f39f2be (PR branch deleted locally).

  7. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    claim: executor=Antigravity session=83b36fa6-8c08-49d6-aeec-63bab02a5e52 scope="Production steps, waiting for next Production promotion (#309 -> main)" branch=antigravity/308-monthly-plan-p3-followups target=2026-11-29

  8. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=83b36fa6-8c08-49d6-aeec-63bab02a5e52 waiting for next Production promotion (dev -> main after JOY approval); #309 merged at dd40557 and deployed to https://beta.give.vn (Vercel success).

  9. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    done: session=83b36fa6-8c08-49d6-aeec-63bab02a5e52 agent=antigravity
    Promoted to Production (2026-11-22):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    line:moneyProduct line: moneypo:agyOwned by Antigravity PO (mutual-exclusion parallel PO label)

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions