Skip to content

Sync CHANGELOG.md / README.md for #250-#253 wave and clean up 2 P3 review nits #299

Closed

Description

@JOY

Goal

Synchronize repository documentation (CHANGELOG.md and README.md if needed) with the newly merged dev / Beta Campaigns wave (#250–#253 and their DOS/DOS.Me DB prerequisites #261–#264, plus #292 CC-PO v2.18.0 config) and batch the 2 minor non-blocking P3 polish items noted during PO reviews.

Requirements

  1. Update CHANGELOG.md (matching its existing structure/style) to record the dev / Beta wave:
    • #252 / PR #295 + #263 / DOS/DOS.Me#1852: Organizer analytics (privacy-safe daily views/referrers/shares & conversion tab)
    • #250 / PR #296 + #262 / DOS/DOS.Me#1853: Campaign comments with one reply level, organizer/moderator controls & reporting
    • #251 / PR #297 + #261 / DOS/DOS.Me#1851: Public organizer profile page (/u/[handle]) & /me handle/bio editor
    • #253 / PR #298 + #264 / DOS/DOS.Me#1856: Co-organizers (single-use invite links, editor workspace guards, strict owner-only money boundary, public team block)
    • #292 / PR #293: CC-PO v2.18.0 parallel PO config (po:agy / po:claude)
    • Check README.md and update only if its feature/route summary is out of date with #250–#253.
  2. Batch 2 minor P3 review nits (with unit test coverage):
    • apps/web/src/lib/analytics.ts: replace bucket in REFERRER_LABELS with Object.hasOwn(REFERRER_LABELS, bucket).
    • apps/web/src/lib/campaign-members.ts: in memberDisplayName, neutralize DB's "Organizer" fallback (case-insensitive) to "Nhà tổ chức" (alongside "co-organizer" -> "Đồng tổ chức").

Approach

  1. Create an isolated git worktree from origin/dev.
  2. Update CHANGELOG.md (and README.md only where stale) and apply the 2 P3 polish nits + targeted unit tests.
  3. Verify pnpm format:check, pnpm lint, pnpm typecheck, targeted vitest run, and pnpm build.
  4. Open PR into dev with Refs #<n>, run fresh-context independent review, wait for CI + PO acceptance, squash merge, and close.

Acceptance

  • CHANGELOG.md accurately documents #250–#253, #261–#264, and #292 without altering earlier entries.
  • Both P3 nits are fixed and covered by passing unit tests.
  • Required CI checks (Lint, Build all apps) and fresh-context independent review pass.
  • Squash-merged into dev via --match-head-commit.

Files

  • CHANGELOG.md
  • README.md (only if stale)
  • apps/web/src/lib/analytics.ts
  • apps/web/src/lib/campaign-members.ts
  • Corresponding unit test files

Activity

  1. added
    po:agyOwned by Antigravity PO (mutual-exclusion parallel PO label)
    on Nov 22, 2026
  2. added theissue type on Nov 22, 2026
  3. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    claim: executor=Antigravity session=82e8ccda-fd2c-4c3e-95cb-c204fa8951fd scope="CHANGELOG.md, README.md, analytics.ts & campaign-members.ts P3 cleanup" branch=antigravity/299-changelog-p3-cleanup target=2026-11-22

  4. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=82e8ccda-fd2c-4c3e-95cb-c204fa8951fd PR #300 opened against dev at d941575 (local format:check, lint, typecheck, targeted vitest 52/52, and build passed). Waiting for CI required checks and independent fresh-context review.

  5. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    done: session=82e8ccda-fd2c-4c3e-95cb-c204fa8951fd

    • PR: docs(campaigns): sync CHANGELOG/README for #250-#253 wave and fix 2 P3 review nits #300 (squashed into dev at c59567691c6a3d1001106c29caad2aa763306c29 from accepted head 840858bf1446005b964b07078afca385772319f0).
    • CI & Reviews: Required checks (Verify build/Lint, Verify build/Build all apps) green; fresh-context independent review CLEAN_PASS; PO independent review APPROVE & PO acceptance posted.
    • Vercel dev/beta deploy (https://beta.give.vn): success — Deployment has completed (https://vercel.com/metados/give/BFz5UCqjij8kbZSsFyNoYfJEsN3D).
    • Production promotion note: The 2 small helper polish fixes (analytics.ts Object.hasOwn and campaign-members.ts "Organizer" fallback neutralization to OWNER_FALLBACK_NAME) ride along with #250–#253 on the next owner-approved dev -> main promotion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    line:campaignsProduct line: campaignspo:agyOwned by Antigravity PO (mutual-exclusion parallel PO label)

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions