Skip to content

Monthly donations A: notify active plan donors when the receiving account is replaced #291

Closed

Description

@JOY

Why

The monthly donations design (§4.3, plan A) says active plan donors must be told when a campaign's receiving account is replaced (#55). #275/#276 left this out of scope. Without it, a donor with a monthly plan keeps a reminder that shows the new account only from the next issue, with no notice that the bank account changed, which looks like a scam risk.

Scope

  • When a receiving-account swap (Replace a disabled receiving account on a live give campaign #55 flow) completes on a campaign with active donation plans, enqueue one notice per active plan donor through give.outbox_enqueue (trigger-side, like the other kinds).
  • Notice states the new account holder name, bank and last digits, the date of the change, and links to the campaign page; it does not ask the donor to transfer.
  • Respect the plan stop link and the email suppression table; no notice for stopped plans.
  • A maximum age for the kind, so a delayed send never goes out stale.

Done when

  • DOS.Me migration + Give template and copy, with tests for: swap with 0, 1, many active plans; stopped plan; donor deleted.
  • Fresh-context review, then PO second review (line:money).

Depends on DOS/DOS.Me#1824 and #290.

Activity

  1. added
    po:agyOwned by Antigravity PO (mutual-exclusion parallel PO label)
    on Nov 22, 2026
  2. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    claim: executor=Antigravity session=da74074e-7c33-44cc-a408-d5a54ab9e2ec scope="DOS/DOS.Me + DOS/Give #291 notify active plan donors on receiving-account swap" branch=antigravity/give-291-plan-swap-notice target=2026-11-23

  3. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=da74074e-7c33-44cc-a408-d5a54ab9e2ec
    Phase 1 DB PR opened: https://github.com/DOS/DOS.Me/pull/1871 (branch antigravity/give-291-plan-swap-notice, head 7ed2a3d36).
    Next: waiting for DOS/DOS.Me required CI checks (Give pgTAP tests, Supabase migration replay, Repository integrity, Validate pnpm lockfile) and running fresh-context flagship security review.

  4. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=da74074e-7c33-44cc-a408-d5a54ab9e2ec
    Phase 1 DB PR https://github.com/DOS/DOS.Me/pull/1871 ready for PO flagship security review & acceptance at head cfe64f85abc858eee1e319eb3f7bf68ad3f29123:

    • Migration: supabase/migrations/20261130130000_give_plan_account_swap_notice.sql (strictly newer than #273 20261130110000 and #77 20261130120000; preserves #273 claim_outbox changes).
    • pgTAP suite: supabase/tests/database/give_plan_account_swap_notice.test.sql (53/53 pass; all 50 Give suites green).
    • Required CI checks (4/4): Give pgTAP tests (dev), Supabase migration replay (dev), Repository integrity, Validate pnpm lockfile all green.
    • Reviews on final head cfe64f85abc858eee1e319eb3f7bf68ad3f29123: dos automated review APPROVED (CLEAN_PASS) + fresh-context flagship security subagent CLEAN_PASS; gemini-code-assist thread addressed (~*) and resolved.
      Next: awaiting PO second review & acceptance before merging Phase 1 and starting Phase 2 (DOS/Give template & copy).
  5. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    PO acceptance: merge at cfe64f85abc858eee1e319eb3f7bf68ad3f29123 (DOS/DOS.Me#1871 -> dev)

  6. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=da74074e-7c33-44cc-a408-d5a54ab9e2ec
    Phase 1 merged & deployed to Beta:

    • DOS/DOS.Me#1871 squashed into dev at 4dd78004d9d511a7624d7b977cc40f0730034b93.
    • Supabase Preview (Beta): success (migration 20261130130000_give_plan_account_swap_notice.sql applied cleanly).
    • Cleaned up DOS.Me worktree and local branch.
      Next: proceeding with Phase 2 (DOS/Give email template, Vietnamese copy, admin labels, and unit tests on branch antigravity/give-291-plan-swap-notice).
  7. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=da74074e-7c33-44cc-a408-d5a54ab9e2ec
    Phase 2 app PR #307 ready for PO flagship money-domain review & acceptance at head 7481687cdcaa99376746cb23d72d2faa10d47f75:

    • Files: apps/web/src/lib/email-outbox.ts, apps/web/src/lib/email-outbox.test.ts, apps/web/src/server/email/templates.ts, apps/web/src/server/email/templates.test.ts, apps/web/src/server/email/outbox.test.ts.
    • Local verification: pnpm test (180/180 files, 2629/2629 tests), pnpm lint, pnpm typecheck, pnpm format:check, pnpm build all green.
    • CI checks: Lint ✅, Build all apps ✅, DOScout ✅, Vercel ✅.
    • Reviews on head 7481687cdcaa99376746cb23d72d2faa10d47f75: dos automated review APPROVED (CLEAN_PASS) + fresh-context independent reviewer CLEAN_PASS.
    • Project Research: Vietnamese bank statement formats and transparent charity accounts (input for P3) #10 updated to In review.
      Next: awaiting PO second review & acceptance before squash-merging into dev.
  8. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=da74074e-7c33-44cc-a408-d5a54ab9e2ec
    Phase 1 + Phase 2 merged to dev and verified on Beta:

    • Phase 1 DB (DOS/DOS.Me#1871, 20261130130000_give_plan_account_swap_notice.sql): squashed into DOS/DOS.Me dev at 4dd78004d9d511a7624d7b977cc40f0730034b93; Supabase Preview (Beta) = success.
    • Phase 2 App (DOS/Give#307, plan_account_swapped template/copy/admin labels/tests): squashed into DOS/Give dev at 98d95583aacec285c4dbcd54cbcc1cc7e374fb0a; Vercel dev/Beta (https://beta.give.vn) = success (https://vercel.com/metados/give/DMukkvw2UWwDcQjp38kMV6y6e85s).
    • Both worktrees and local branches removed cleanly.
      Issue kept OPEN pending Production (dev -> main) promotion.
  9. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    handoff: session=da74074e-7c33-44cc-a408-d5a54ab9e2ec to=83b36fa6-8c08-49d6-aeec-63bab02a5e52
    Done: Phase 1 DB migration (DOS/DOS.Me#1871, 20261130130000_give_plan_account_swap_notice.sql + 53 pgTAP tests) merged into DOS/DOS.Me dev at 4dd78004d9d511a7624d7b977cc40f0730034b93; Phase 2 app template, Vietnamese copy, admin outbox labels & unit tests (DOS/Give#307) merged into DOS/Give dev at 98d95583aacec285c4dbcd54cbcc1cc7e374fb0a.
    Evidence: DOS.Me required CI (4/4: Give pgTAP tests 50 suites including 53/53 new assertions, Supabase migration replay, Repository integrity, Validate pnpm lockfile), dos APPROVED, fresh-context flagship security review CLEAN_PASS, PO acceptance, and Supabase Preview (Beta) = success. Give local (pnpm test 180/180 files 2629/2629 tests, lint, typecheck, format:check, build) + CI (Lint, Build all apps, DOScout, Vercel), dos APPROVED, fresh-context review CLEAN_PASS, PO acceptance, and Vercel dev/Beta (https://beta.give.vn, https://vercel.com/metados/give/DMukkvw2UWwDcQjp38kMV6y6e85s) = success.
    Remaining: Production promotion (DOS/DOS.Me dev -> main first, then DOS/Give dev -> main) after owner approval, followed by Production verification and done: / close.
    Next step: Include DOS/DOS.Me#1871 (4dd78004d9d511a7624d7b977cc40f0730034b93) and DOS/Give#307 (98d95583aacec285c4dbcd54cbcc1cc7e374fb0a) in the next PO-led Production promotion batch.
    Blockers: none (awaiting Production promotion window / owner approval).
    Branch: merged and cleaned up (DOS/DOS.Me dev at 4dd78004d9d511a7624d7b977cc40f0730034b93, DOS/Give dev at 98d95583aacec285c4dbcd54cbcc1cc7e374fb0a; local worktrees and branches removed).

  10. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    claim: executor=Antigravity session=83b36fa6-8c08-49d6-aeec-63bab02a5e52 scope="Production steps, waiting for next Production promotion (DOS/DOS.Me#1871 + #307 -> main)" branch=antigravity/give-291-plan-swap-notice target=2026-11-29

  11. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=83b36fa6-8c08-49d6-aeec-63bab02a5e52 waiting for next Production promotion (dev -> main after JOY approval); Phase 1 DOS/DOS.Me#1871 merged at 4dd78004d9d511a7624d7b977cc40f0730034b93 (Supabase Preview Beta success) and Phase 2 #307 merged at 98d9558 (Vercel https://beta.give.vn success).

  12. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    done: session=83b36fa6-8c08-49d6-aeec-63bab02a5e52 agent=antigravity
    Promoted to Production (2026-11-22):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    line:moneyProduct line: moneypo:agyOwned by Antigravity PO (mutual-exclusion parallel PO label)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions