Skip to content

Mesh Handle: is_conformal for elements and meshes using neighbor cache - #2622

Open
Vyp3er wants to merge 16 commits into
mainfrom
mesh_handle_is_conformal
Open

Vyp3er wants to merge 16 commits into
mainfrom
mesh_handle_is_conformal

Conversation

@Vyp3er

@Vyp3er Vyp3er commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #2430

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • README.md files are updated if necessary.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.07%. Comparing base (aa533c8) to head (b44a9b7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2622      +/-   ##
==========================================
+ Coverage   83.05%   83.07%   +0.02%     
==========================================
  Files         148      148              
  Lines       22259    22274      +15     
==========================================
+ Hits        18488    18505      +17     
+ Misses       3771     3769       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread mesh_handle/mesh.hxx Resolved
Comment thread mesh_handle/element.hxx Resolved
@lenaploetzke lenaploetzke assigned Vyp3er and unassigned lenaploetzke Oct 26, 2026
@Vyp3er Vyp3er assigned lenaploetzke and unassigned Vyp3er Oct 29, 2026
Comment thread mesh_handle/element.hxx Resolved
@lenaploetzke lenaploetzke assigned Vyp3er and unassigned lenaploetzke Oct 29, 2026
@Vyp3er Vyp3er assigned lenaploetzke and unassigned Vyp3er Oct 30, 2026

@lenaploetzke lenaploetzke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls clean up the history

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add is_conformal check to mesh handle

3 participants