Repository navigation
Feature: mesh deformation with RBFs (TPS and CPC2) - #2470
Lena-Richter wants to merge 36 commits into
Conversation
…o the rbf_node struct and the interpolate function. add some minor changes to the mesh deformation to include the rbf_node struct to save the node data.
bbfd954 to
d05a2e2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
==========================================
+ Coverage 83.05% 83.35% +0.29%
==========================================
Files 148 147 -1
Lines 22259 22179 -80
==========================================
Hits 18488 18488
+ Misses 3771 3691 -80 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ole-alb
left a comment
There was a problem hiding this comment.
Thank you for this very cool contribution and implementation. I have a couple general remarks.
Can you check if ervything that can be const is const?
Please add tests for your functionality as it is not tested yet. Please also test the new dependecy on the newly added thirdparty library Eigen.
After the PR is merged, please keep in mind to update the wiki accordingly (Eigen, CMake,..).
Also I thought if there could be the option to use a system Eigen like it is for SC and p4est?
And last but not least, I coudn't find you in the CITATION.cff and in doc/auther_. Please add yourself here.
…on.cxx Co-authored-by: Ole Albers <122293607+ole-alb@users.noreply.github.com>
…s, robust thirdparty options
| add_t8_example( NAME t8_rbf_test SOURCES cmesh/t8_rbf.cxx ) | ||
| target_link_libraries( t8_rbf_test PRIVATE Eigen3::Eigen ) |
There was a problem hiding this comment.
The build fails, because the file isn't remove from here. This also lead me to notice that the new CMake option is not enabled anywhere in the CI. So your CI ran through even though the build fails.
| family-names: George | ||
| email: Janot.George@dlr.de | ||
| affiliation: "German Aerospace Center (DLR)" | ||
| given-names: Lena-René |
There was a problem hiding this comment.
| given-names: Lena-René | |
| - given-names: Lena-René |
| email: F.Becker@dlr.de | ||
| affiliation: "German Aerospace Center (DLR)" | ||
| orcid: "https://orcid.org/0000-0002-8384-9282" | ||
|
|
There was a problem hiding this comment.
Why did you remove Florians Orcid?
|
Heyho, |
Closes #2471
Describe your changes here:
This PR introduces an RBF-based mesh deformation, using OpenCASCADE and Eigen. It implements support for the compactly supported (
CPC2) and globally supported (TPS) basis functions to compute the deformation for the inner nodes from the displacement of the boundary nodes. Additionally, for CPC2, a dynamic radius is implemented as well as a grading factor. The deformed geometry needs to have the same parametrization as the input geometry, otherwise the deformation will not work.All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).